This repository has been archived by the owner on Aug 2, 2022. It is now read-only.
Final CDT key value cleanup #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Has not execute integration test yet due to some link issue with eos on my local machine. |
|
Verified tests, everything is passing |
jeffreyssmith2nd
approved these changes
Aug 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the key value API in EOSIO.CDT has the prefix 'kv_' used almost everywhere. This is problematic in a couple of ways, one is that the user has to type 'kv_' a lot and it is a bit reminiscent of C style "namespacing". So, we should simply add the namespace 'kv' over these data types. These names will also need to be updated in tests, abigen, and docs.
It also, appears that 'kv_singleton' either made its way back in or it fully wasn't removed in any of the previous PRs. This data type can be massive foot gun for developers and it is difficult to concisely express the semantics of it. The remedy is to just remove the data type 'kv_singleton' and any usages from the tests.
Change Description
API Changes
Documentation Additions