disable copy constructor and copy assignment

[allenhan2]

Due to the way those types are initialized, it is not safe to allow the copy constructor or copy-assignment operator on the kv table type.

Change Description

• disable copy constructor and assignment
• disable move constructor and assignment

API Changes

• API Changes

Documentation Additions

• Documentation Additions

Doc team, please make sure our examples were not using these accidentally, thanks.

[larryk85]

What is currently unsafe about it?

[tbfleming]

It holds internal pointers to index members

[tbfleming]

Which, BTW, is also incompatible with move. That should also be disabled.

[allenhan2]

Which, BTW, is also incompatible with move. That should also be disabled.

Could you please elaborate a scenario for problem of move? thanks!

[tbfleming]

Simplification of what's going on:

struct foo {
    int a = 0;
    int* p;

    foo(): p{&a} {}
};

[allenhan2]

It is a great example, but could it happen in the table class? disable move will make hard for utility functions.

[tbfleming]

Like I said above, kv_table does this. It's part of how it keeps track of indexes.

[allenhan2]

okay, then, will disable the move.

[allenhan2]

no permission to merge, submitted tick for permission, https://blockone.freshservice.com/support/tickets/15178

[allenhan2]

@b1bart could you give another review, the merge is blocked by the request change, thanks,