Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support partial trie fetching and move mutable to trie-memory #58

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

sorpaas
Copy link
Contributor

@sorpaas sorpaas commented Feb 27, 2018

This implements two things and fixes several tests:

  • Support partial trie. DatabaseHandle is changed to allow returning
    Option, and all op fns will return Error::Require(hash) if one of
    the hash is missing in the database. Client can use this information
    to further retrieve the required hash and try again.
  • trie now contains a mostly stable interface. Mutable structs
    interface may change a lot, and they're moved to trie-memory crate.

This implements two things and fixes several tests:

* Support partial trie. DatabaseHandle is changed to allow returning
  Option, and all op fns will return Error::Require(hash) if one of
  the hash is missing in the database. Client can use this information
  to further retrieve the required hash and try again.
* trie now contains a mostly stable interface. Mutable structs
  interface may change a lot, and they're moved to trie-memory crate.
@sorpaas sorpaas requested a review from a team February 27, 2018 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant