Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify how to include these libraries #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pyskell
Copy link

@pyskell pyskell commented Mar 21, 2018

Not sure how you're doing versioning so I edited this assuming that any version within the 0 major version number is fine.

Also suggest changing the naming scheme so that Cargo.toml and main.rs match up better (like emerald-rs / emerald_rs does). Hopefully it's early enough that it's trivial to get any 3rd-party uses of the library updated.

@CLAassistant
Copy link

CLAassistant commented Mar 21, 2018

CLA assistant check
All committers have signed the CLA.

@whilei whilei requested review from tzdybal and r8d8 March 21, 2018 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants