BOLT updates 2020-01 #3474
Merged
BOLT updates 2020-01 #3474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…e a fee. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Fixed: Now correctly reject "fees" paid when we're the final hop (lightning-rfc#711)
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We tag them with specific versions when they're experimental, but do a poor job of cleaning them up (and thus ensuring they're checked!) afterwards. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We also update since the merged version sets feature bit 9 (as it's supposed to now that we tied that to payment_secret). Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
ZmnSCPxj
approved these changes
Jan 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usefully, this caught a spec fix we hadn't implemented.