Add address to GetAvailableUtxos in NodeguardService

[RodriFS]

No description provided.

[markettes]

LGTM

[daliclovr]

@RodriFS can you explain to me what is considered an AvailableUTXO? I imagine that is something like "your utxo is not spent but is being used (i,e lightning channel)". Are unavailablesUTXO marked as locked? how are they marked?

[RodriFS]

@RodriFS can you explain to me what is considered an AvailableUTXO? I imagine that is something like "your utxo is not spent but is being used (i,e lightning channel)". Are unavailablesUTXO marked as locked? how are they marked?

That's exactly right. Avaliable utxos are locked in a request or frozen.
There is a different on how we manage locked and frozen utxos:

• the locked utxos are not marked, each time you request the list of available utxos, we go and check if there is a request that is taking hold of that utxos and we don't add those to the list
• the frozen utxos are marked with a flag in the database

You can see the implementation here:

NodeGuard/src/Data/Repositories/FUTXORepository.cs

Line 108 in 69c1acf

public async Task<List<FMUTXO>> GetLockedUTXOs(int? ignoredWalletWithdrawalRequestId = null, int? ignoredChannelOperationRequestId = null)

[daliclovr]

@RodriFS can you explain to me what is considered an AvailableUTXO? I imagine that is something like "your utxo is not spent but is being used (i,e lightning channel)". Are unavailablesUTXO marked as locked? how are they marked?

That's exactly right. Avaliable utxos are locked in a request or frozen. There is a different on how we manage locked and frozen utxos:

• the locked utxos are not marked, each time you request the list of available utxos, we go and check if there is a request that is taking hold of that utxos and we don't add those to the list
• the frozen utxos are marked with a flag in the database

You can see the implementation here:

NodeGuard/src/Data/Repositories/FUTXORepository.cs

Line 108 in 69c1acf

public async Task<List<FMUTXO>> GetLockedUTXOs(int? ignoredWalletWithdrawalRequestId = null, int? ignoredChannelOperationRequestId = null)

@RodriFS I feel that what you clarify to me today, the difference between locked and frozen should be reflected somewhere. Both status means the same in the sense of utxos are not usable if locked or frozen, although frozen is a "permanent" status and locked is a computed status based on others. Is quite confusing if this information is not added anywhere...

[RodriFS]

@RodriFS can you explain to me what is considered an AvailableUTXO? I imagine that is something like "your utxo is not spent but is being used (i,e lightning channel)". Are unavailablesUTXO marked as locked? how are they marked?

That's exactly right. Avaliable utxos are locked in a request or frozen. There is a different on how we manage locked and frozen utxos:

• the locked utxos are not marked, each time you request the list of available utxos, we go and check if there is a request that is taking hold of that utxos and we don't add those to the list
• the frozen utxos are marked with a flag in the database

You can see the implementation here:

NodeGuard/src/Data/Repositories/FUTXORepository.cs

Line 108 in 69c1acf

public async Task<List<FMUTXO>> GetLockedUTXOs(int? ignoredWalletWithdrawalRequestId = null, int? ignoredChannelOperationRequestId = null)

@RodriFS I feel that what you clarify to me today, the difference between locked and frozen should be reflected somewhere. Both status means the same in the sense of utxos are not usable if locked or frozen, although frozen is a "permanent" status and locked is a computed status based on others. Is quite confusing if this information is not added anywhere...

@daliclovr please review the PR again. We removed the IsFrozen flag on the utxos, and now we just use the tags to know the status of a utxo. So we don't have to register utxos in the table at all, we just tag utxos comming from the nbxplorer

The base branch was changed.

[daliclovr]

@RodriFS can you explain to me what is considered an AvailableUTXO? I imagine that is something like "your utxo is not spent but is being used (i,e lightning channel)". Are unavailablesUTXO marked as locked? how are they marked?

That's exactly right. Avaliable utxos are locked in a request or frozen. There is a different on how we manage locked and frozen utxos:

• the locked utxos are not marked, each time you request the list of available utxos, we go and check if there is a request that is taking hold of that utxos and we don't add those to the list
• the frozen utxos are marked with a flag in the database

You can see the implementation here:

NodeGuard/src/Data/Repositories/FUTXORepository.cs

Line 108 in 69c1acf

public async Task<List<FMUTXO>> GetLockedUTXOs(int? ignoredWalletWithdrawalRequestId = null, int? ignoredChannelOperationRequestId = null)

@RodriFS I feel that what you clarify to me today, the difference between locked and frozen should be reflected somewhere. Both status means the same in the sense of utxos are not usable if locked or frozen, although frozen is a "permanent" status and locked is a computed status based on others. Is quite confusing if this information is not added anywhere...

@daliclovr please review the PR again. We removed the IsFrozen flag on the utxos, and now we just use the tags to know the status of a utxo. So we don't have to register utxos in the table at all, we just tag utxos comming from the nbxplorer

@RodriFS how can you tag the utxos in advance without knowing the score? What is the status to consider them locked now?