Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add Expression::original() #26

Merged
merged 1 commit into from
Mar 16, 2021
Merged

Conversation

gdesmott
Copy link
Contributor

Checklist

  • I have read the Contributor Guide
  • I have read and agree to the Code of Conduct
  • I have added a description of my changes and why I'd like them included in the section below

Description of Changes

add Expression::original()

My parser is storing an Expression and may have to retrieve the original string later when producing errors.

Copy link
Member

@Jake-Shadle Jake-Shadle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Are you planning on doing more changes? If so I'll hold off doing releases for each small PR.

src/expr/mod.rs Outdated Show resolved Hide resolved
My parser is storing an Expression and may have to retrieve the original
string later when producing errors.
@gdesmott
Copy link
Contributor Author

I think I'm good now, but let me come back to you once I'm done implementing my thing. Should be ready soon. :)

@Jake-Shadle Jake-Shadle merged commit f998b00 into EmbarkStudios:main Mar 16, 2021
@gdesmott gdesmott deleted the expr-original branch March 16, 2021 10:29
@gdesmott
Copy link
Contributor Author

All good, I managed to implement my exact use case!

Thanks a lot for the very quick reviews and releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants