switch TargetInfo to using Cow<'static, str> #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may let users of `TargetInfo` skip using lifetime params, while still allowing creation at compile time using string literals. For convenience, I've also added a `Triple` newtype wrapper, as well as implemented a number of methods on all the newtype wrappers (including the existing ones). Closes EmbarkStudios#30.
sunshowers
force-pushed
the
drop-lifetime
branch
from
732e736
to
810428b
Compare
|
let me know if this makes sense to you -- I have another PR that upgrades to rust 1.54 as well :) |
Jake-Shadle
approved these changes
Aug 19, 2021
|
Thanks, I'll try putting up a PR with the required changes for 1.54 tomorrow, it's a bit involved since there's a new target family |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description of Changes
This may let users of
TargetInfoskip using lifetime params,while still allowing creation at compile time using string literals.
For convenience, I've also added a
Triplenewtype wrapper, as well asimplemented a number of methods on all the newtype wrappers (including
the existing ones).
Related Issues
Closes #30.