Use wrapped strings for target components #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, auto-generate all of the builtin targets as named constants, so we preserve the previous behavior we got with enums, but allow the use of non-builtin target specs as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various components of target triples such as environment, vendor, and operating system can be specified externally from rustc via custom targets. This change allows cfg-expr to still evaluate those custom targets, as before they would not be parsed due to them being closed sets of only the builtin targets of rustc.
This also adds optional support for the
target-lexiconcrate (behind thetargetsfeature flag) so that more targets than the builtin ones can be more easily evaluated against an expression.Resolves: #8