Fixes response.capabilities undefined error when using custom geocoder without ArcGIS Online Geoocoder. #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
without ArcGIS Online Geoocoder.
|
if i had read the doc more closely when incorporating the new logic, i would have known that 'capabilities' wasn't introduced until 10.3. thanks for the bug fix @npeihl! @patrickarlt i'll plan on tagging a new release after merging. |
jgravois
added a commit
that referenced
this pull request
Jul 15, 2015
Fixes response.capabilities undefined error when using custom geocoder without ArcGIS Online Geoocoder.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest update to the plugin breaks because the response.capabilities is undefined on an ArcGIS Server 10.2 custom geocode service. This appears to fix the issue.
I've created a gist showing how the debug/sample.html would look with our custom geocode service. I didn't include my changes to debug/sample.html in the commit.