Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve tests #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

danheberden
Copy link

Changed compressed.js to run all the tests for every compressed* folder in the testData directory to a) simplify the tests and b) make it easier to add more archives to test

… to make adding tests easier. Also added test for node-archiver, which jqueryui uses.
@danheberden
Copy link
Author

I updated the tests with jQueryUI's custom zip and bootstrap's zip, two that we've had problems with specifically with Bower. This fails on 0.10.3 and 0.8.22

removing the jQueryUI one causes the tests to hang on extracting bootstrap.zip. Hopefully this helps in diagnosing and testing what is wrong :/

no jQueryUI test on 0.8.22:

no jQueryUI test on 0.10.3

@satazor
Copy link

satazor commented Apr 19, 2013

Bump!

@sindresorhus
Copy link

bump

@paulirish
Copy link

@nearinfinity can you review this PR soon? It's blocking us pretty hard. :/

@ralphholzmann
Copy link
Contributor

bump!

@paulirish
Copy link

@nearinfinity can you try to merge this soon and bump the package. thank you!

@sindresorhus
Copy link

@EvanOxfeld ^

@ralphholzmann
Copy link
Contributor

Yes plz.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants