Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue 37, where entry.size is undefined. #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

filtersweep
Copy link

This is just a real quick first pass, with little knowledge of the rest of the codebase. The crux of the issue is that entry.size is unassigned before the "entry" event is emitted. I couldn't find anywhere where vars.uncompressedSize and vars.flags are re-assigned between the initial assignment and the usage after fileSizeKnown. So, I just moved that block up before "entry" is emitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant