Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lobby_api querying #461

Merged
merged 1 commit into from
Nov 13, 2023
Merged

Remove lobby_api querying #461

merged 1 commit into from
Nov 13, 2023

Conversation

Brutus5000
Copy link
Member

This is unused since new website (was bugged anyway) and currently stops moving the website to Kubernetes.

@fcaps
Copy link
Collaborator

fcaps commented Nov 12, 2023

there was a comment from @JaviTrek

### lobby_api
reinstated after it seems it is actually being used and is not some useless piece of code. It provides users with a mirror of the users, their maps and lobbies in the FAF client.

But nonetheless, it's broken.
Can you also remove the LOBBY_API_URL in .env.example, env.faf-stack and in the faf-stack repo?
Also the readme can be updated The website has dependencies to

This is unused since new website (was bugged anyway) and currently stops moving the website to Kubernetes.
@fcaps
Copy link
Collaborator

fcaps commented Nov 13, 2023

lgtm :) thx for the update

@fcaps
Copy link
Collaborator

fcaps commented Nov 13, 2023

you know where it was used? in the old game-client?

@Brutus5000
Copy link
Member Author

It used to show the number of current players online and games played. At some point there was also a world map where we showed where the players are.

@Brutus5000
Copy link
Member Author

But this could be brought back with a proper grafana chart integration maybe.

@Brutus5000 Brutus5000 merged commit ccc3adf into develop Nov 13, 2023
3 checks passed
@fcaps
Copy link
Collaborator

fcaps commented Nov 13, 2023

i see, was curios where this was used, did not find any ref in the game-client

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants