feat(scroll-duration): add animate effect to auto scroll #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Terminal colors (FEMessage#10)
snowlocked
changed the title
auto-add-label
bot
added
enhancement
|
Deploy preview for log-viewer ready! Built with commit cd144d7 |
lianghx-319
reviewed
Dec 2, 2019
|
在 styleguide 上可能会丢失了 docs/get.js 需要处理一下。把请求写到 md 中？ |
added 2 commits
December 2, 2019 16:13
lianghx-319
approved these changes
Dec 2, 2019
lianghx-319
reviewed
Dec 2, 2019
levy9527
changed the title
levy9527
reviewed
Dec 3, 2019
| @@ -139,6 +147,42 @@ export default { | |||
| return { | |||
| props | |||
| } | |||
| }, | |||
| setScrollTop(line) { | |||
There was a problem hiding this comment.
好像算法需要修正：demo里，使用手机秒表计算，实际滚动时间粗略估计1.6秒。。。
levy9527
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
现状：自动滚动到底部是一瞬间到底，没有过渡过程。需要添加一个滚动过渡动画
How
通过每一帧设置scrollTop到特定值来达到滚动动画效果
Attention
目前存在性能问题，duration 实际时间比设置时间更长