Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BG4 plugin fix & BackwardLz77 logic revert #296

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

SomeKitten
Copy link

The BG4 plugin's saving feature was completely non-functional from my testing with Superstar Saga DX / Bowser's Inside Story DX as I reported in #295

Two changes:

  • I made the paths used when saving relative which fixed name and hash discrepancies.
  • I'm not entirely familiar as to why the BackwardLz77 encoding/decoding was changed previously, but reverting those changes seems to fix issues with the BG4 plugin. This algorithm is also used by the HpiHpb plugin, so I have a feeling that the revert may also fix issues with that plugin if they occurred. The alternative is that this change would break that plugin which may be concerning. Since the plugin was last update before the original BackwardLz77 rewrite, I am inclined to believe that it should work with my revert.

I highly recommend that someone who has access to HpiHpb files use the plugin with the reverted algorithm to make sure it is functional with the changes!!

If preferred, I can split this into two PRs, but I figured its alright for this to be one PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant