Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix code duplication in the newHash (Triage on ostracon#509) #14

Closed
Tracked by #1
0Tech opened this issue Nov 1, 2023 · 1 comment
Closed
Tracked by #1

Fix code duplication in the newHash (Triage on ostracon#509) #14

0Tech opened this issue Nov 1, 2023 · 1 comment
Assignees
@Mdaiki0730

Comments

@0Tech
Copy link

0Tech commented Nov 1, 2023 •
edited by Mdaiki0730
Loading

The subject of the triage:
@0Tech 0Tech mentioned this issue Nov 1, 2023
Open
50 tasks
@Mdaiki0730
Copy link
Member

As of v0.38.0, there is no function with the same name, but there is a function that seems to be an alternative.
https://github.com/cometbft/cometbft/blob/v0.38.0/p2p/pex/addrbook.go#L112-L119

This seems to have been fixed by tendermint#9445 to improve performance.
The code written in crypto.CRandBytes has been modified to be reused.
tendermint/tendermint#9445

It seems that there is no need to reflect it in cometbft.

@Mdaiki0730 Mdaiki0730 changed the title Triage on ostracon#509 Fix code duplication in the newHash (Triage on ostracon#509) Nov 6, 2023
@0Tech 0Tech closed this as not planned Won't fix, can't repro, duplicate, stale Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mdaiki0730 Mdaiki0730

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0Tech @Mdaiki0730