EPIC: triage the PRs from Finschia/ostracon

[0Tech]

We should make decisions on the following PRs from Finschia/ostracon.

Targets

Uncategorized

• improve performance of a crypt marshaller (ostracon#177) #2
  • feat: crypto custom marshaller ostracon#177
• Set the default config for the db backend from the available options #3
  • chore: use default db backend among the available ones ostracon#212
• Optimize checking the txs size in ReapMaxBytesMaxGas() #4
  • perf: optimize checking the txs size ostracon#264
• Perf: prevent from flushing in WAL(Triage on ostracon#273) #5
  • perf: do not flush wal when receive consensus msgs ostracon#273
• Introduce max txs per block #6
  • feat: added max txs per block to config.toml ostracon#317
• Fix the thread-unsafe of PeerState logging #7
  • Fix the thread-unsafe of PeerState logging ostracon#458
• Avoid panic when addr does not exist in book (Triage on ostracon#484) #8
  • Avoid panic when addr does not exist in book ostracon#484
• Optimization of function signChallenge() (Triage on ostracon#485) #9
  • Optimization of function signChallenge() ostracon#485
• Use the value receiver instead of the pointer receiver in Pubkey.Identity() (Triage on ostracon#492) #10
  • Use the value receiver instead of the pointer receiver in Pubkey.Identity() ostracon#492
• Update the http status code handling on upnp (Triage on ostracon#497) #11
  • fix: Update the http status code handling on upnp ostracon#497
• Fix overriding tx index of duplicated txs (Triage on ostracon#498) #12
  • fix: fix overriding tx index of duplicated txs ostracon#498
• Return error when AddChannel fails (Triage on ostracon#500) #13
  • fix: return error when AddChannel fails ostracon#500
• Fix code duplication in the newHash (Triage on ostracon#509) #14
  • Fix code duplication in the newHash ostracon#509
• Add unique handling of servers (Triage on ostracon#515) #15
  • Add unique handling of servers ostracon#515
• Fix app version of example app (ostracon #533) #16
  • Fix the mismatch between "State.Version.Consensus.App" and "State.ConsensusParams.Version.AppVersion" ostracon#533
• Support log rotation #17
  • feat: zerolog based rolling log system ostracon#535
• Split marshaled genesis before saving it to the DB #18
  • feat: big genesis file ostracon#576
• Triage on ostracon#135 #19
  • feat: async reactor receiving ostracon#135

Async

• Triage on ostracon#160 #20
  • feat: concurrent checkTx ostracon#160
• Triage on ostracon#162 #21
  • fix: revise to call Begin/EndRecheck even though mem.Size() is 0 ostracon#162
• Triage on ostracon#163 #22
  • feat: concurrent recheckTx ostracon#163
• Triage on ostracon#168 #23
  • feat: impl checkTxAsyncReactor() ostracon#168
• Triage on ostracon#169 #24
  • chore: revise abci.Client, Async() interfaces ostracon#169
• Triage on ostracon#341 #25
  • Remove default case ostracon#341
• Triage on ostracon#394 #26
  • fix: Remove panic for unexpected tx response in resCbRecheck ostracon#394
• Triage on ostracon#404 #27
  • Improve checking tx with txsMap for fixing the inconsistency between mem.txs and mem.txsMap ostracon#404
• Triage on ostracon#507 #28
  • fix: return postCheck error to abci client ostracon#507

Removal

• Perf: remove one of ABCI transport(socket)(Triage on ostracon#153) #29
  • chore: remove abci socket implementation ostracon#153
• grpc_client_test and fix grpc_client StopForError() hang bug #30
  • test: grpc_client_test and fix grpc_client StopForError() hang bug ostracon#155
• Triage on ostracon#156 #31
  • chore: remove abci flush() ostracon#156
• Delete an unused function (ostracon#508) #32
  • Remove unsed the functioin StateProvider ostracon#508
• Remove Ping() which is not in use anymore #33
  • fix: remove strange Ping ostracon#523

KMS

• Add KMS functionality(Triage on ostracon#417) #34
  • Add KMS functionality ostracon#417
• Support multiple allow ip for kms connection(Triage on ostracon#692) #35
  • feat: add remote IP filter to allow a connection from remote kms ostracon#692
• Support single allow ip for kms connection(Triage on ostracon#707) #36
  • feat: support multiple allowIPs for a remote connection from one of KMS servers ostracon#707

Connection liveness

• Add extra node timeout setting & json-rpc client connection setting #37
  • chore: connection pool and read timeout ostracon#131
• add timeout configs (ostracon#150) #38
  • chore: config timeout and connection pool ostracon#150
• Change the maximum number of items per page from 100 to 10000 #39
  • chore: increase the value of maxPerPage ostracon#223
• Add timeout for some of HTTP request(Triage on ostracon#506) #40
  • Fix so that HTTP request don't wait for responses indefinitely ostracon#506
• Add support for dns lookup timeout #41
  • fix: add support for dns timeout ostracon#527
• Avoid multiple requests DDoS to rpc entpoints (ostracon#672) #42
  • feat: add max_batch_request_num feature ostracon#672

New query

• Introduce tx_by_height endpoint to circumvent pagination #43
  • feat: implement TxByHeight ostracon#138
• Triage on ostracon#151 #44
  • feat: txs_by_height rpc api ostracon#151

Metric

• Metrics for additional consensus step duration(Triage on ostracon#126) #45
  • feat: add some metrics measuring consensus step duration ostracon#126
• Add more prometheus metric for block exec, commit and tx recheck #46
  • feat: metric for block exec, commit and tx recheck ostracon#132
• Fix a pref branch's metrix bug (ostracon#133) #47
  • fix: reset recheckTimeMs ostracon#133
• Metrics for additional app commit duration(Triage on ostracon#136) #48
  • chore: metric for block app commit time ostracon#136
• Add more prometheus metrics(BlockAppCommitTime, BlockUpdateMempoolTime) #49
  • feat: more prometheus metrics for monitoring performance ostracon#146
• Add gauge type metrics for finalizeCommit #50
  • feat: add duration metrics of gauge type ostracon#256
• Add some timing info log (ostracon#324) #51
  • chore: added extra timing info regarding block generation ostracon#324

Decision

1. Abandon it, which means just closing the corresponding issue. You should provide your opinion.
2. Submit the corresponding PR to the upstream, cometbft/cometbft.

Procedure

1. Pick an issue and assign yourself.
2. Update the issue title and provide the link for the corresponding PR of ostracon.
3. Make a decision.