Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add max_batch_request_num feature #672

Merged
merged 14 commits into from
Jul 28, 2023
Merged

feat: add max_batch_request_num feature #672

merged 14 commits into from
Jul 28, 2023

Conversation

170210
Copy link
Contributor

@170210 170210 commented Jul 20, 2023 •
edited
Loading

Description

This PR has following changes.

  • add a limitation feature called max_batch_request_num to control the requests size

Closes: #649

@170210
chore: add a new parameter to the configuration
d0ad145 
Signed-off-by: 170210 <j170210@icloud.com>
@CLAassistant
Copy link

CLAassistant commented Jul 20, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jul 20, 2023 •
edited
Loading

Codecov Report

Merging #672 (287be47) into main (1cab268) will increase coverage by 0.07%.
Report is 6 commits behind head on main.
The diff coverage is 88.13%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #672      +/-   ##
==========================================
+ Coverage   66.51%   66.59%   +0.07%     
==========================================
  Files         283      283              
  Lines       37818    37869      +51     
==========================================
+ Hits        25155    25219      +64     
+ Misses      10868    10854      -14     
- Partials     1795     1796       +1
Files Changed Coverage Δ
cmd/ostracon/commands/light.go 15.72% <0.00%> (-0.10%) ⬇️
config/toml.go 74.19% <ø> (ø)
rpc/core/routes.go 0.00% <ø> (ø)
rpc/jsonrpc/server/http_json_handler.go 67.36% <64.70%> (-0.27%) ⬇️
config/config.go 79.36% <100.00%> (+0.16%) ⬆️
node/node.go 61.49% <100.00%> (+0.07%) ⬆️
rpc/jsonrpc/server/http_server.go 91.01% <100.00%> (+1.40%) ⬆️
rpc/jsonrpc/server/ws_handler.go 35.71% <100.00%> (+0.77%) ⬆️

... and 12 files with indirect coverage changes

@170210 170210 self-assigned this Jul 20, 2023
@170210 170210 added C: enhancement Classification: New feature or its request, or improvement in maintainability of code D: good first issue Decision: Good for newcomers labels Jul 20, 2023
@170210 170210 marked this pull request as ready for review July 20, 2023 05:15
@170210 170210 marked this pull request as draft July 20, 2023 07:16
@170210 170210 marked this pull request as ready for review July 20, 2023 09:48
@170210 170210 marked this pull request as draft July 21, 2023 02:02
@170210 170210 marked this pull request as ready for review July 21, 2023 04:57
@170210
feat: add max_request_batch_request feature in Ostracon
5567e39 
Signed-off-by: 170210 <j170210@icloud.com>
@170210
test: add test in http_json_handler_test
c315f7a 
Signed-off-by: 170210 <j170210@icloud.com>
@170210 170210 force-pushed the feature/issue_649 branch 3 times, most recently from 34f8849 to f135d56 Compare July 25, 2023 01:57
@170210
test: add the field to http header of existing tests
6ea2cbb 
Signed-off-by: 170210 <j170210@icloud.com>
@170210
test: add test in http_server_test
785b82f 
Signed-off-by: 170210 <j170210@icloud.com>
@170210
fixup: merge main
8cf9862 
Signed-off-by: 170210 <j170210@icloud.com>
@170210
fixup: add field to merged tests
c386e40 
Signed-off-by: 170210 <j170210@icloud.com>
@170210 170210 requested a review from zemyblue July 25, 2023 05:41
zemyblue
zemyblue reviewed Jul 26, 2023
View reviewed changes
config/config.go Outdated Show resolved Hide resolved
@170210 170210 changed the title feat: add max_request_batch_request feature feat: add max_batch_request_num feature Jul 27, 2023
@170210
refactor: change to max_batch_request_num
b13a54f 
Signed-off-by: 170210 <j170210@icloud.com>
@170210
fixup: fix goroutine leaks in test
b871455 
Signed-off-by: 170210 <j170210@icloud.com>
@170210
fixup: fix warning when defer in a loop
980d957 
Signed-off-by: 170210 <j170210@icloud.com>
@170210 170210 requested a review from zemyblue July 27, 2023 08:34
ulbqb
ulbqb reviewed Jul 27, 2023
View reviewed changes
node/node.go Outdated Show resolved Hide resolved
rpc/jsonrpc/server/common_test.go Outdated Show resolved Hide resolved
rpc/jsonrpc/server/http_json_handler.go Outdated Show resolved Hide resolved
@170210
style: fix for comment
31dde18 
Signed-off-by: 170210 <j170210@icloud.com>
@170210
refactor: change request header key
6790199 
Signed-off-by: 170210 <j170210@icloud.com>
@170210 170210 requested a review from ulbqb July 27, 2023 09:27
tnasu
tnasu reviewed Jul 27, 2023
View reviewed changes
node/node.go Show resolved Hide resolved
@170210
fixup: fix for review
5a5466f 
Signed-off-by: 170210 <j170210@icloud.com>
@170210
fixup: add field in light client
287be47 
Signed-off-by: 170210 <j170210@icloud.com>
@170210 170210 requested a review from tnasu July 27, 2023 10:53
@170210 170210 merged commit 59b58b6 into Finschia:main Jul 28, 2023
23 checks passed
@0Tech 0Tech mentioned this pull request Nov 1, 2023
Open
50 tasks
@loloicci loloicci mentioned this pull request Nov 9, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tnasu tnasu tnasu approved these changes

@zemyblue zemyblue zemyblue approved these changes

@torao torao Awaiting requested review from torao

@ulbqb ulbqb Awaiting requested review from ulbqb ulbqb is a code owner

Assignees

@170210 170210

Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code D: good first issue Decision: Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

jsonrpc 2.0 batch request limits required
5 participants
@170210 @CLAassistant @tnasu @zemyblue @ulbqb