Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid multiple requests DDoS to rpc entpoints (ostracon#672) #42

Open
Tracked by #1
0Tech opened this issue Nov 1, 2023 · 3 comments
Open
Tracked by #1

Avoid multiple requests DDoS to rpc entpoints (ostracon#672) #42

0Tech opened this issue Nov 1, 2023 · 3 comments
Assignees
Labels

Comments

@0Tech
Copy link

0Tech commented Nov 1, 2023

The subject of the triage:

@loloicci
Copy link

loloicci commented Nov 9, 2023

Finschia/ostracon#672 adds a request limit to rpc endpoint. This is for avoiding DDoS. But @ulbqb says that it is unnecessary. Finschia/ostracon#649 (comment)

@loloicci
Copy link

loloicci commented Nov 9, 2023

Now, MaxBodyBytes is enough big value to contain a contract in Finschia. So we need this limit to avoid DDoS.

@loloicci
Copy link

We can suggest it to upstream.

@loloicci loloicci changed the title Triage on ostracon#672 Aboid multiple requests DDoS to rpc entpoints (ostracon#672) Nov 15, 2023
@loloicci loloicci changed the title Aboid multiple requests DDoS to rpc entpoints (ostracon#672) Avoid multiple requests DDoS to rpc entpoints (ostracon#672) Nov 15, 2023
@0Tech 0Tech added A: improvement Changes in existing functionality priority/major A: feature New features and removed A: improvement Changes in existing functionality labels Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants