Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: zerolog based rolling log system #535

Merged
merged 4 commits into from
Dec 20, 2022

Conversation

dudong2
Copy link
Contributor

@dudong2 dudong2 commented Dec 16, 2022

Description

Currently, log level setting by module and rotation log system are not available in lbm-sdk's log system. In order to support these functions, a zerolog-based extended log system is implemented.

Closes: #825

@dudong2 dudong2 self-assigned this Dec 16, 2022
@CLAassistant
Copy link

CLAassistant commented Dec 16, 2022

CLA assistant check
All committers have signed the CLA.

@tnasu tnasu added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Dec 16, 2022
@codecov
Copy link

codecov bot commented Dec 16, 2022

Codecov Report

Merging #535 (4f0af64) into main (e8f0b19) will increase coverage by 0.11%.
The diff coverage is 82.55%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #535      +/-   ##
==========================================
+ Coverage   66.03%   66.14%   +0.11%     
==========================================
  Files         279      280       +1     
  Lines       38045    38119      +74     
==========================================
+ Hits        25122    25213      +91     
+ Misses      11123    11107      -16     
+ Partials     1800     1799       -1     
Impacted Files Coverage Δ
config/toml.go 74.19% <ø> (ø)
libs/log/zerolog_logger.go 77.94% <77.94%> (ø)
cmd/ostracon/commands/root.go 37.50% <100.00%> (ø)
config/config.go 78.36% <100.00%> (+0.26%) ⬆️
libs/log/log_level.go 84.21% <100.00%> (ø)
abci/client/socket_client.go 72.09% <0.00%> (-0.88%) ⬇️
p2p/pex/addrbook.go 71.06% <0.00%> (-0.51%) ⬇️
consensus/reactor.go 74.75% <0.00%> (-0.36%) ⬇️
proxy/multi_app_conn.go 47.66% <0.00%> (ø)
blockchain/v0/pool.go 79.06% <0.00%> (+0.25%) ⬆️
... and 5 more

@Kynea0b
Copy link
Contributor

Kynea0b commented Dec 19, 2022

Thanks for the PR. e2e and r2ishiguro require several tests to succeed, so please retry. @dudong2

@dudong2
Copy link
Contributor Author

dudong2 commented Dec 19, 2022

Thanks for the PR. e2e and r2ishiguro require several tests to succeed, so please retry. @dudong2

After 7 retries, it passed. The e2e-test has a very frequent failure rate. There were no cases of failure on my local. Do you know why there are so many failures? If it is opened to external developers in the future, is there any plan to revise this test?

Copy link
Contributor

@Kynea0b Kynea0b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dudong2 dudong2 merged commit 617efcd into Finschia:main Dec 20, 2022
@dudong2 dudong2 deleted the dudong2/feat/improve-logger branch December 20, 2022 09:00
@tnasu
Copy link
Member

tnasu commented Dec 22, 2022

After 7 retries, it passed. The e2e-test has a very frequent failure rate. There were no cases of failure on my local. Do you know why there are so many failures? If it is opened to external developers in the future, is there any plan to revise this test?

This PR reduced the failure rate. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analysis and improve log management function.
4 participants