feat: add zerolog based rolling log system #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #883 +/- ##
==========================================
- Coverage 62.45% 62.45% -0.01%
==========================================
Files 653 652 -1
Lines 79873 79854 -19
==========================================
- Hits 49884 49872 -12
+ Misses 27298 27292 -6
+ Partials 2691 2690 -1
|
dudong2
requested review from
zemyblue,
0Tech,
jaeseung-bae,
loin3 and
tkxkd0159
and removed request for
zemyblue
tkxkd0159
previously approved these changes
Feb 8, 2023
zemyblue
reviewed
Feb 8, 2023
zemyblue
approved these changes
Feb 9, 2023
0Tech
approved these changes
Feb 9, 2023
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, chains based on cosmos-sdk only have the ability to output logs to the console. So far, we've been using pipes to store them as a single file. If the chain has been started for a long time, the size of the log file becomes too large and maintenance is difficult. So, the rolling log system has been added to Finschia/ostracon#535, and I want to use it in lbm-sdk.
closes: #837
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml