Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more prometheus metrics(BlockAppCommitTime, BlockUpdateMempoolTime) #49

Closed
Tracked by #1
0Tech opened this issue Nov 1, 2023 · 3 comments
Closed
Tracked by #1

Add more prometheus metrics(BlockAppCommitTime, BlockUpdateMempoolTime) #49

0Tech opened this issue Nov 1, 2023 · 3 comments
Assignees
@tkxkd0159
Labels
priority/minor

Comments

@0Tech
Copy link

0Tech commented Nov 1, 2023 •
edited
Loading

The subject of the triage:
@0Tech 0Tech mentioned this issue Nov 1, 2023
Open
50 tasks
@tkxkd0159
Copy link
Member

Similar to #46

Just add more prometheus metrics(BlockAppCommitTime, BlockUpdateMempoolTime)

@tkxkd0159 tkxkd0159 changed the title Triage on ostracon#146 Add more prometheus metrics(BlockAppCommitTime, BlockUpdateMempoolTime) Nov 7, 2023
@tkxkd0159 tkxkd0159 changed the title Add more prometheus metrics(BlockAppCommitTime, BlockUpdateMempoolTime) Add more prometheus metrics(BlockAppCommitTime, BlockUpdateMempoolTime) Nov 7, 2023
@0Tech
Copy link
Author

0Tech commented Nov 15, 2023

We should consult with the clients about the usage.

@tkxkd0159
Copy link
Member

Follow up at #53

@tkxkd0159 tkxkd0159 mentioned this issue Nov 16, 2023
Open
tkxkd0159 pushed a commit that referenced this issue Apr 24, 2024
@jmalicevic @andynog @melekes
feat(pruning): trigger explicitly compaction upon pruning (cometbft#1972
cfe8b88 
)

Blocked on cometbft/cometbft-db#111 and
benchmarking


Addresses #49 

Upon pruning we explicitly call the compaction function of the DB
backend. This has shown to immediately shrink the storage footprint.

We need to evaluate the duration of this compaction depending on the
storage size to be able to reason about the impact on Comet's regular
operations.

ToDo: 
-Extend the `storage` config section with following parameters:
- [ ] `in-process-compaction = false #Enable or disable in-process
compaction. False by default`
- [ ] `in-process-compaction-interval = 10 #Interval in number of blocks
to trigger explicit compaction; 10 by default`



<!--

Please add a reference to the issue that this PR addresses and indicate
which
files are most critical to review. If it fully addresses a particular
issue,
please include "Closes #XXX" (where "XXX" is the issue number).

If this PR is non-trivial/large/complex, please ensure that you have
either
created an issue that the team's had a chance to respond to, or had some
discussion with the team prior to submitting substantial pull requests.
The team
can be reached via GitHub Discussions or the Cosmos Network Discord
server in
the #cometbft channel. GitHub Discussions is preferred over Discord as
it
allows us to keep track of conversations topically.
https://github.com/cometbft/cometbft/discussions

If the work in this PR is not aligned with the team's current
priorities, please
be advised that it may take some time before it is merged - especially
if it has
not yet been discussed with the team.

See the project board for the team's current priorities:
https://github.com/orgs/cometbft/projects/1

-->

---

#### PR checklist

- [ ] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments

---------

Co-authored-by: Andy Nogueira <me@andynogueira.dev>
Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
tkxkd0159 pushed a commit that referenced this issue Apr 24, 2024
@jmalicevic @melekes
docs: Copy description of section on compaction to docs (cometbft#2600)
63f2629 
Addresses #49 

<!--

Please add a reference to the issue that this PR addresses and indicate
which
files are most critical to review. If it fully addresses a particular
issue,
please include "Closes #XXX" (where "XXX" is the issue number).

If this PR is non-trivial/large/complex, please ensure that you have
either
created an issue that the team's had a chance to respond to, or had some
discussion with the team prior to submitting substantial pull requests.
The team
can be reached via GitHub Discussions or the Cosmos Network Discord
server in
the #cometbft channel. GitHub Discussions is preferred over Discord as
it
allows us to keep track of conversations topically.
https://github.com/cometbft/cometbft/discussions

If the work in this PR is not aligned with the team's current
priorities, please
be advised that it may take some time before it is merged - especially
if it has
not yet been discussed with the team.

See the project board for the team's current priorities:
https://github.com/orgs/cometbft/projects/1

-->

---

#### PR checklist

- [ ] Tests written/updated
- [ ] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [ ] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [ ] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec

---------

Co-authored-by: Anton Kaliaev <anton.kalyaev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tkxkd0159 tkxkd0159

Labels
priority/minor
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@0Tech @tkxkd0159