Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsed the functioin StateProvider #508

Merged
merged 1 commit into from
Nov 25, 2022

Conversation

tnasu
Copy link
Member

@tnasu tnasu commented Nov 24, 2022

Description

The function StateProvider() is used to override the state provider in the state sync case. It is unstable and easy to change, and currently, the function is not used anywhere in the codebase. So I remove the aforementioned function for code maintenance.

@codecov
Copy link

codecov bot commented Nov 24, 2022

Codecov Report

Merging #508 (d7ef80d) into main (e6f57a1) will increase coverage by 0.16%.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
+ Coverage   65.39%   65.55%   +0.16%     
==========================================
  Files         278      278              
  Lines       37995    37968      -27     
==========================================
+ Hits        24846    24890      +44     
+ Misses      11328    11273      -55     
+ Partials     1821     1805      -16     
Impacted Files Coverage Δ
node/node.go 60.44% <ø> (+0.24%) ⬆️
abci/client/socket_client.go 72.09% <0.00%> (-0.88%) ⬇️
p2p/conn/connection.go 79.80% <0.00%> (-0.20%) ⬇️
consensus/state.go 73.15% <0.00%> (-0.12%) ⬇️
crypto/vrf/vrf_libsodium.go
crypto/vrf/vrf_r2ishiguro.go 100.00% <0.00%> (ø)
p2p/switch.go 66.52% <0.00%> (+0.61%) ⬆️
types/voter_set.go 85.62% <0.00%> (+0.84%) ⬆️
blockchain/v0/pool.go 79.06% <0.00%> (+1.03%) ⬆️
consensus/reactor.go 75.37% <0.00%> (+1.14%) ⬆️
... and 5 more

@tnasu tnasu self-assigned this Nov 24, 2022
@tnasu tnasu marked this pull request as ready for review November 24, 2022 11:23
@torao torao added the C: enhancement Classification: New feature or its request, or improvement in maintainability of code label Nov 24, 2022
@ulbqb ulbqb self-requested a review November 25, 2022 03:18
@tnasu tnasu merged commit 99fc39b into Finschia:main Nov 25, 2022
@tnasu tnasu deleted the main-stateprovider branch November 25, 2022 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: enhancement Classification: New feature or its request, or improvement in maintainability of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants