Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: introduce detailed breaking sections in CHANGELOG #1113

Merged
merged 6 commits into from
Sep 8, 2023

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Sep 6, 2023

Description

This patch would introduce following sections into CHANGELOG.md.

  • Event Breaking Change
  • State Machine Breaking

Motivation and context

Our client considers the changes in the events as Client Breaking. Hence, we added another section, "Event Breaking" and will keep tracking on it.

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech self-assigned this Sep 6, 2023
@0Tech 0Tech added this to the v0.48.0 milestone Sep 6, 2023
@0Tech 0Tech marked this pull request as ready for review September 6, 2023 06:56
jaeseung-bae
jaeseung-bae previously approved these changes Sep 6, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@0Tech 0Tech changed the title chore: introduce Event Breaking section in CHANGELOG chore: introduce detailed breaking sections in CHANGELOG Sep 7, 2023
@0Tech 0Tech requested a review from zemyblue September 7, 2023 12:52
CHANGELOG.md Outdated Show resolved Hide resolved
@0Tech 0Tech requested a review from zemyblue September 8, 2023 01:48
@0Tech 0Tech merged commit 5e22d9d into Finschia:rc/v0.48.0-rcx Sep 8, 2023
32 checks passed
@0Tech 0Tech deleted the changelog-v2 branch September 8, 2023 04:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants