Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement validateGasWanted() (#48) #142

Merged
merged 1 commit into from
Apr 22, 2021

Conversation

jinsan-line
Copy link
Contributor

@jinsan-line jinsan-line commented Apr 22, 2021

Epic: line/lbm#1262

Cherry-pick: #48

Description

Validate GasWanted during ante handler. It's need to remove tendermint mempool.postCheck().
It should reconstruct the same logic with https://github.com/line/tendermint/blob/a01efd28c7257d3b056d1fcf263d39ccea3c1273/mempool/mempool.go#L126


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

* feat: impl `validateGasWanted()`

* fix: lint error

* chore: bump up tendermint

* fix: tests to use `grpc` instead of `socket`
# Conflicts:
#	go.mod
#	go.sum
#	server/start.go
#	x/genutil/client/cli/init_test.go
@jinsan-line jinsan-line added this to the Initail ebony milestone Apr 22, 2021
@jinsan-line jinsan-line self-assigned this Apr 22, 2021
@jinsan-line jinsan-line merged commit 0072984 into v2/develop Apr 22, 2021
@jinsan-line jinsan-line deleted the jinsan/v2/check-gas-in-ante branch April 22, 2021 08:47
brew0722 pushed a commit that referenced this pull request Apr 26, 2021
Add genesis ex-/import for `lastContractId` sequence
@egonspace egonspace mentioned this pull request Sep 23, 2021
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants