Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: local multi node test setting files #334

Merged
merged 2 commits into from
Oct 1, 2021
Merged

chore: local multi node test setting files #334

merged 2 commits into from
Oct 1, 2021

Conversation

dudong2
Copy link
Contributor

@dudong2 dudong2 commented Sep 30, 2021

Description

update init_node.sh and README.md file for local multi node test

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@dudong2 dudong2 self-assigned this Sep 30, 2021
Copy link

@egonspace egonspace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that this script performs well.

init_node.sh Outdated Show resolved Hide resolved
@egonspace egonspace self-requested a review October 1, 2021 02:39
Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applying the comments in my environment (Debian), it looks like working. 👍

README.md Outdated Show resolved Hide resolved
init_node.sh Outdated Show resolved Hide resolved
init_node.sh Outdated Show resolved Hide resolved
Copy link
Collaborator

@0Tech 0Tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked it working 👍

@dudong2 dudong2 merged commit f35dabc into Finschia:main Oct 1, 2021
@dudong2 dudong2 deleted the leesj9476/chore/init-multi-node branch October 1, 2021 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants