fix: change the default value of the client output format in the config #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0Tech
changed the title
Codecov Report
@@ Coverage Diff @@
## main #476 +/- ##
=======================================
Coverage 55.78% 55.78%
=======================================
Files 719 719
Lines 73829 73829
=======================================
Hits 41184 41184
Misses 29537 29537
Partials 3108 3108
|
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It fixes the confusing behavior discussed in #473.
It's not a bug, but we concluded not to set the default value on the output format in the config file.
closes: #473
Motivation and context
#473
How has this been tested?
Executed tx cli and confirmed the output is in json.
Also confirmed the output of query cli is in yaml.
Tested on Docker image, on Debian bookworm.
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml