docs: update outdated events in specs #602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zemyblue
reviewed
Jul 20, 2022
|
|
||
| # Events of LBM-SDK | ||
|
|
||
| Note: the content of this document is based on the actual implementation in version 0.45.6 of the cosmos-sdk. As we do not intend to introduce a new specification, it's a bug of the documentation if you find any differences between this document and the implementation. |
There was a problem hiding this comment.
Current lbm-sdk is based on cosmos-sdk v0.45.1. But we need to bump up
There was a problem hiding this comment.
cosmos-sdk version up issue was added in #575 . Please check it later.
0Tech
commented
Jul 21, 2022
0Tech
commented
Jul 21, 2022
dudong2
approved these changes
Jul 21, 2022
zemyblue
approved these changes
Jul 21, 2022
| | transfer | amount | {amount} | | ||
| | message | module | bank | | ||
| | message | action | send | |
There was a problem hiding this comment.
Why message.actions are removed at document?
There was a problem hiding this comment.
Some modules do not have the event of type `message' in its document. So, I decided to put the event into the common document, and remove it from the individual module's.
dudong2
pushed a commit
to dudong2/lbm-sdk
that referenced
this pull request
Aug 1, 2022
* docs: update x/bank events * docs: update x/crisis events * docs: update x/distribution events * docs: update x/evidence events * docs: update x/feegrant events * docs: update x/gov events * docs: update x/slashing events * docs: update x/staking events * docs: add x/collection events * docs: update x/foundation events * docs: add x/token events * docs: add common spec of events into docs * docs: fix typo * docs: update CHANGELOG.md * docs: narrow the context * Update docs/core/event.md * Update docs/core/event.md
96 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update outdated documentation about the events.
It also adds common specification about the events.
Checklist:
CHANGELOG.mdclient/docs/swagger-ui/swagger.yaml