Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove legacy events on x/collection and x/token #966

Merged
merged 6 commits into from
Apr 14, 2023
Merged

fix: remove legacy events on x/collection and x/token #966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
23d6961
Remove x/collection legacy events from proto
0Tech Apr 14, 2023
477bb61
Remove x/collection legacy events logic
0Tech Apr 14, 2023
dbb18d5
Remove x/token legacy events from proto
0Tech Apr 14, 2023
c4bbb6f
Remove x/token legacy events logic
0Tech Apr 14, 2023
3c282db
Remove comments
0Tech Apr 14, 2023
5f2e05a
Update CHANGELOG.md
0Tech Apr 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (x/collection,token) [\#957](https://github.com/line/lbm-sdk/pull/957) Refactor queries of x/collection and x/token

### Removed
* (x/collection,token) [\#966](https://github.com/line/lbm-sdk/pull/966) Remove legacy events on x/collection and x/token

### Breaking Changes
* (proto) [\#923](https://github.com/line/lbm-sdk/pull/923) deprecate broadcast mode `block`
Expand Down
95 changes: 0 additions & 95 deletions docs/core/proto-docs.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -648,7 +648,6 @@
- [EventSent](#lbm.collection.v1.EventSent)

- [AttributeKey](#lbm.collection.v1.AttributeKey)
- [EventType](#lbm.collection.v1.EventType)

- [lbm/collection/v1/genesis.proto](#lbm/collection/v1/genesis.proto)
- [Balance](#lbm.collection.v1.Balance)
Expand Down Expand Up @@ -885,7 +884,6 @@
- [EventSent](#lbm.token.v1.EventSent)

- [AttributeKey](#lbm.token.v1.AttributeKey)
- [EventType](#lbm.token.v1.EventType)

- [lbm/token/v1/genesis.proto](#lbm/token/v1/genesis.proto)
- [Balance](#lbm.token.v1.Balance)
Expand Down Expand Up @@ -9690,76 +9688,17 @@ Since: 0.46.0 (finschia)
<a name="lbm.collection.v1.AttributeKey"></a>

### AttributeKey
Deprecated: use typed events.

AttributeKey enumerates the valid attribute keys on x/collection.

| Name | Number | Description |
| ---- | ------ | ----------- |
| ATTRIBUTE_KEY_UNSPECIFIED | 0 | |
| ATTRIBUTE_KEY_NAME | 1 | |
| ATTRIBUTE_KEY_META | 2 | |
| ATTRIBUTE_KEY_CONTRACT_ID | 3 | |
| ATTRIBUTE_KEY_TOKEN_ID | 4 | |
| ATTRIBUTE_KEY_OWNER | 5 | |
| ATTRIBUTE_KEY_AMOUNT | 6 | |
| ATTRIBUTE_KEY_DECIMALS | 7 | |
| ATTRIBUTE_KEY_BASE_IMG_URI | 8 | deprecated: use ATTRIBUTE_KEY_URI |
| ATTRIBUTE_KEY_MINTABLE | 9 | |
| ATTRIBUTE_KEY_TOKEN_TYPE | 10 | |
| ATTRIBUTE_KEY_FROM | 11 | |
| ATTRIBUTE_KEY_TO | 12 | |
| ATTRIBUTE_KEY_PERM | 13 | |
| ATTRIBUTE_KEY_TO_TOKEN_ID | 14 | |
| ATTRIBUTE_KEY_FROM_TOKEN_ID | 15 | |
| ATTRIBUTE_KEY_APPROVER | 16 | |
| ATTRIBUTE_KEY_PROXY | 17 | |
| ATTRIBUTE_KEY_OLD_ROOT_TOKEN_ID | 18 | |
| ATTRIBUTE_KEY_NEW_ROOT_TOKEN_ID | 19 | |
| ATTRIBUTE_KEY_URI | 20 | |



<a name="lbm.collection.v1.EventType"></a>

### EventType
Deprecated: use typed events.

EventType enumerates the valid event types on x/collection.

| Name | Number | Description |
| ---- | ------ | ----------- |
| EVENT_TYPE_UNSPECIFIED | 0 | |
| EVENT_TYPE_CREATE_COLLECTION | 1 | |
| EVENT_TYPE_ISSUE_FT | 2 | |
| EVENT_TYPE_ISSUE_NFT | 3 | |
| EVENT_TYPE_MINT_FT | 4 | |
| EVENT_TYPE_BURN_FT | 5 | |
| EVENT_TYPE_MINT_NFT | 6 | |
| EVENT_TYPE_BURN_NFT | 7 | |
| EVENT_TYPE_BURN_FT_FROM | 8 | |
| EVENT_TYPE_BURN_NFT_FROM | 9 | |
| EVENT_TYPE_MODIFY_COLLECTION | 10 | |
| EVENT_TYPE_MODIFY_TOKEN_TYPE | 11 | |
| EVENT_TYPE_MODIFY_TOKEN | 12 | |
| EVENT_TYPE_TRANSFER | 13 | |
| EVENT_TYPE_TRANSFER_FT | 14 | |
| EVENT_TYPE_TRANSFER_NFT | 15 | |
| EVENT_TYPE_TRANSFER_FT_FROM | 16 | |
| EVENT_TYPE_TRANSFER_NFT_FROM | 17 | |
| EVENT_TYPE_GRANT_PERM | 18 | |
| EVENT_TYPE_REVOKE_PERM | 19 | |
| EVENT_TYPE_ATTACH | 20 | |
| EVENT_TYPE_DETACH | 21 | |
| EVENT_TYPE_ATTACH_FROM | 22 | |
| EVENT_TYPE_DETACH_FROM | 23 | |
| EVENT_TYPE_APPROVE_COLLECTION | 24 | |
| EVENT_TYPE_DISAPPROVE_COLLECTION | 25 | |
| EVENT_TYPE_OPERATION_TRANSFER_NFT | 26 | |
| EVENT_TYPE_OPERATION_BURN_NFT | 27 | |
| EVENT_TYPE_OPERATION_ROOT_CHANGED | 28 | |


<!-- end enums -->

<!-- end HasExtensions -->
Expand Down Expand Up @@ -13166,45 +13105,11 @@ AttributeKey enumerates the valid attribute keys on x/token.
| ---- | ------ | ----------- |
| ATTRIBUTE_KEY_UNSPECIFIED | 0 | |
| ATTRIBUTE_KEY_NAME | 1 | |
| ATTRIBUTE_KEY_SYMBOL | 2 | |
| ATTRIBUTE_KEY_META | 3 | |
| ATTRIBUTE_KEY_CONTRACT_ID | 4 | |
| ATTRIBUTE_KEY_OWNER | 5 | |
| ATTRIBUTE_KEY_AMOUNT | 6 | |
| ATTRIBUTE_KEY_DECIMALS | 7 | |
| ATTRIBUTE_KEY_IMG_URI | 8 | deprecated: use ATTRIBUTE_KEY_URI |
| ATTRIBUTE_KEY_MINTABLE | 9 | |
| ATTRIBUTE_KEY_FROM | 10 | |
| ATTRIBUTE_KEY_TO | 11 | |
| ATTRIBUTE_KEY_PERM | 12 | |
| ATTRIBUTE_KEY_APPROVER | 13 | |
| ATTRIBUTE_KEY_PROXY | 14 | |
| ATTRIBUTE_KEY_URI | 15 | |



<a name="lbm.token.v1.EventType"></a>

### EventType
Deprecated: use typed events.

EventType enumerates the valid event types on x/token.

| Name | Number | Description |
| ---- | ------ | ----------- |
| EVENT_TYPE_UNSPECIFIED | 0 | |
| EVENT_TYPE_ISSUE | 1 | |
| EVENT_TYPE_MINT | 2 | |
| EVENT_TYPE_BURN | 3 | |
| EVENT_TYPE_BURN_FROM | 4 | |
| EVENT_TYPE_MODIFY_TOKEN | 5 | |
| EVENT_TYPE_TRANSFER | 6 | |
| EVENT_TYPE_TRANSFER_FROM | 7 | |
| EVENT_TYPE_GRANT_PERM | 8 | |
| EVENT_TYPE_REVOKE_PERM | 9 | |
| EVENT_TYPE_APPROVE_TOKEN | 10 | |


<!-- end enums -->

<!-- end HasExtensions -->
Expand Down
62 changes: 4 additions & 58 deletions proto/lbm/collection/v1/event.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,46 +7,6 @@ import "lbm/collection/v1/collection.proto";

option go_package = "github.com/line/lbm-sdk/x/collection";

// Deprecated: use typed events.
//
// EventType enumerates the valid event types on x/collection.
enum EventType {
option (gogoproto.goproto_enum_stringer) = false;
option (gogoproto.goproto_enum_prefix) = false;

EVENT_TYPE_UNSPECIFIED = 0 [(gogoproto.enumvalue_customname) = "EventTypeUnspecified"];
EVENT_TYPE_CREATE_COLLECTION = 1 [(gogoproto.enumvalue_customname) = "EventTypeCreateCollection"];
EVENT_TYPE_ISSUE_FT = 2 [(gogoproto.enumvalue_customname) = "EventTypeIssueFT"];
EVENT_TYPE_ISSUE_NFT = 3 [(gogoproto.enumvalue_customname) = "EventTypeIssueNFT"];
EVENT_TYPE_MINT_FT = 4 [(gogoproto.enumvalue_customname) = "EventTypeMintFT"];
EVENT_TYPE_BURN_FT = 5 [(gogoproto.enumvalue_customname) = "EventTypeBurnFT"];
EVENT_TYPE_MINT_NFT = 6 [(gogoproto.enumvalue_customname) = "EventTypeMintNFT"];
EVENT_TYPE_BURN_NFT = 7 [(gogoproto.enumvalue_customname) = "EventTypeBurnNFT"];
EVENT_TYPE_BURN_FT_FROM = 8 [(gogoproto.enumvalue_customname) = "EventTypeBurnFTFrom"];
EVENT_TYPE_BURN_NFT_FROM = 9 [(gogoproto.enumvalue_customname) = "EventTypeBurnNFTFrom"];
EVENT_TYPE_MODIFY_COLLECTION = 10 [(gogoproto.enumvalue_customname) = "EventTypeModifyCollection"];
EVENT_TYPE_MODIFY_TOKEN_TYPE = 11 [(gogoproto.enumvalue_customname) = "EventTypeModifyTokenType"];
EVENT_TYPE_MODIFY_TOKEN = 12 [(gogoproto.enumvalue_customname) = "EventTypeModifyToken"];
EVENT_TYPE_TRANSFER = 13 [(gogoproto.enumvalue_customname) = "EventTypeTransfer"];
EVENT_TYPE_TRANSFER_FT = 14 [(gogoproto.enumvalue_customname) = "EventTypeTransferFT"];
EVENT_TYPE_TRANSFER_NFT = 15 [(gogoproto.enumvalue_customname) = "EventTypeTransferNFT"];
EVENT_TYPE_TRANSFER_FT_FROM = 16 [(gogoproto.enumvalue_customname) = "EventTypeTransferFTFrom"];
EVENT_TYPE_TRANSFER_NFT_FROM = 17 [(gogoproto.enumvalue_customname) = "EventTypeTransferNFTFrom"];
EVENT_TYPE_GRANT_PERM = 18 [(gogoproto.enumvalue_customname) = "EventTypeGrantPermToken"];
EVENT_TYPE_REVOKE_PERM = 19 [(gogoproto.enumvalue_customname) = "EventTypeRevokePermToken"];
EVENT_TYPE_ATTACH = 20 [(gogoproto.enumvalue_customname) = "EventTypeAttachToken"];
EVENT_TYPE_DETACH = 21 [(gogoproto.enumvalue_customname) = "EventTypeDetachToken"];
EVENT_TYPE_ATTACH_FROM = 22 [(gogoproto.enumvalue_customname) = "EventTypeAttachFrom"];
EVENT_TYPE_DETACH_FROM = 23 [(gogoproto.enumvalue_customname) = "EventTypeDetachFrom"];
EVENT_TYPE_APPROVE_COLLECTION = 24 [(gogoproto.enumvalue_customname) = "EventTypeApproveCollection"];
EVENT_TYPE_DISAPPROVE_COLLECTION = 25 [(gogoproto.enumvalue_customname) = "EventTypeDisapproveCollection"];
EVENT_TYPE_OPERATION_TRANSFER_NFT = 26 [(gogoproto.enumvalue_customname) = "EventTypeOperationTransferNFT"];
EVENT_TYPE_OPERATION_BURN_NFT = 27 [(gogoproto.enumvalue_customname) = "EventTypeOperationBurnNFT"];
EVENT_TYPE_OPERATION_ROOT_CHANGED = 28 [(gogoproto.enumvalue_customname) = "EventTypeOperationRootChanged"];
}

// Deprecated: use typed events.
//
// AttributeKey enumerates the valid attribute keys on x/collection.
enum AttributeKey {
option (gogoproto.goproto_enum_stringer) = false;
Expand All @@ -55,25 +15,11 @@ enum AttributeKey {
ATTRIBUTE_KEY_UNSPECIFIED = 0 [(gogoproto.enumvalue_customname) = "AttributeKeyUnspecified"];
ATTRIBUTE_KEY_NAME = 1 [(gogoproto.enumvalue_customname) = "AttributeKeyName"];
ATTRIBUTE_KEY_META = 2 [(gogoproto.enumvalue_customname) = "AttributeKeyMeta"];
ATTRIBUTE_KEY_CONTRACT_ID = 3 [(gogoproto.enumvalue_customname) = "AttributeKeyContractID"];
ATTRIBUTE_KEY_TOKEN_ID = 4 [(gogoproto.enumvalue_customname) = "AttributeKeyTokenID"];
ATTRIBUTE_KEY_OWNER = 5 [(gogoproto.enumvalue_customname) = "AttributeKeyOwner"];
ATTRIBUTE_KEY_AMOUNT = 6 [(gogoproto.enumvalue_customname) = "AttributeKeyAmount"];
ATTRIBUTE_KEY_DECIMALS = 7 [(gogoproto.enumvalue_customname) = "AttributeKeyDecimals"];
reserved 3 to 7;
// deprecated: use ATTRIBUTE_KEY_URI
ATTRIBUTE_KEY_BASE_IMG_URI = 8 [(gogoproto.enumvalue_customname) = "AttributeKeyBaseImgURI"];
ATTRIBUTE_KEY_MINTABLE = 9 [(gogoproto.enumvalue_customname) = "AttributeKeyMintable"];
ATTRIBUTE_KEY_TOKEN_TYPE = 10 [(gogoproto.enumvalue_customname) = "AttributeKeyTokenType"];
ATTRIBUTE_KEY_FROM = 11 [(gogoproto.enumvalue_customname) = "AttributeKeyFrom"];
ATTRIBUTE_KEY_TO = 12 [(gogoproto.enumvalue_customname) = "AttributeKeyTo"];
ATTRIBUTE_KEY_PERM = 13 [(gogoproto.enumvalue_customname) = "AttributeKeyPerm"];
ATTRIBUTE_KEY_TO_TOKEN_ID = 14 [(gogoproto.enumvalue_customname) = "AttributeKeyToTokenID"];
ATTRIBUTE_KEY_FROM_TOKEN_ID = 15 [(gogoproto.enumvalue_customname) = "AttributeKeyFromTokenID"];
ATTRIBUTE_KEY_APPROVER = 16 [(gogoproto.enumvalue_customname) = "AttributeKeyApprover"];
ATTRIBUTE_KEY_PROXY = 17 [(gogoproto.enumvalue_customname) = "AttributeKeyProxy"];
ATTRIBUTE_KEY_OLD_ROOT_TOKEN_ID = 18 [(gogoproto.enumvalue_customname) = "AttributeKeyOldRoot"];
ATTRIBUTE_KEY_NEW_ROOT_TOKEN_ID = 19 [(gogoproto.enumvalue_customname) = "AttributeKeyNewRoot"];
ATTRIBUTE_KEY_URI = 20 [(gogoproto.enumvalue_customname) = "AttributeKeyURI"];
ATTRIBUTE_KEY_BASE_IMG_URI = 8 [(gogoproto.enumvalue_customname) = "AttributeKeyBaseImgURI"];
reserved 9 to 19;
ATTRIBUTE_KEY_URI = 20 [(gogoproto.enumvalue_customname) = "AttributeKeyURI"];
}

// EventSent is emitted when tokens are transferred.
Expand Down
43 changes: 7 additions & 36 deletions proto/lbm/token/v1/event.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,50 +7,21 @@ import "lbm/token/v1/token.proto";

option go_package = "github.com/line/lbm-sdk/x/token";

// Deprecated: use typed events.
//
// EventType enumerates the valid event types on x/token.
enum EventType {
option (gogoproto.goproto_enum_stringer) = false;
option (gogoproto.goproto_enum_prefix) = false;

EVENT_TYPE_UNSPECIFIED = 0 [(gogoproto.enumvalue_customname) = "EventTypeUnspecified"];

EVENT_TYPE_ISSUE = 1 [(gogoproto.enumvalue_customname) = "EventTypeIssueToken"];
EVENT_TYPE_MINT = 2 [(gogoproto.enumvalue_customname) = "EventTypeMintToken"];
EVENT_TYPE_BURN = 3 [(gogoproto.enumvalue_customname) = "EventTypeBurnToken"];
EVENT_TYPE_BURN_FROM = 4 [(gogoproto.enumvalue_customname) = "EventTypeBurnTokenFrom"];
EVENT_TYPE_MODIFY_TOKEN = 5 [(gogoproto.enumvalue_customname) = "EventTypeModifyToken"];
EVENT_TYPE_TRANSFER = 6 [(gogoproto.enumvalue_customname) = "EventTypeTransfer"];
EVENT_TYPE_TRANSFER_FROM = 7 [(gogoproto.enumvalue_customname) = "EventTypeTransferFrom"];
EVENT_TYPE_GRANT_PERM = 8 [(gogoproto.enumvalue_customname) = "EventTypeGrantPermToken"];
EVENT_TYPE_REVOKE_PERM = 9 [(gogoproto.enumvalue_customname) = "EventTypeRevokePermToken"];
EVENT_TYPE_APPROVE_TOKEN = 10 [(gogoproto.enumvalue_customname) = "EventTypeApproveToken"];
}

// AttributeKey enumerates the valid attribute keys on x/token.
enum AttributeKey {
option (gogoproto.goproto_enum_stringer) = false;
option (gogoproto.goproto_enum_prefix) = false;

ATTRIBUTE_KEY_UNSPECIFIED = 0 [(gogoproto.enumvalue_customname) = "AttributeKeyUnspecified"];

ATTRIBUTE_KEY_NAME = 1 [(gogoproto.enumvalue_customname) = "AttributeKeyName"];
ATTRIBUTE_KEY_SYMBOL = 2 [(gogoproto.enumvalue_customname) = "AttributeKeySymbol"];
ATTRIBUTE_KEY_META = 3 [(gogoproto.enumvalue_customname) = "AttributeKeyMeta"];
ATTRIBUTE_KEY_CONTRACT_ID = 4 [(gogoproto.enumvalue_customname) = "AttributeKeyContractID"];
ATTRIBUTE_KEY_OWNER = 5 [(gogoproto.enumvalue_customname) = "AttributeKeyOwner"];
ATTRIBUTE_KEY_AMOUNT = 6 [(gogoproto.enumvalue_customname) = "AttributeKeyAmount"];
ATTRIBUTE_KEY_DECIMALS = 7 [(gogoproto.enumvalue_customname) = "AttributeKeyDecimals"];
ATTRIBUTE_KEY_NAME = 1 [(gogoproto.enumvalue_customname) = "AttributeKeyName"];
reserved 2;
ATTRIBUTE_KEY_META = 3 [(gogoproto.enumvalue_customname) = "AttributeKeyMeta"];
reserved 4 to 7;
// deprecated: use ATTRIBUTE_KEY_URI
ATTRIBUTE_KEY_IMG_URI = 8 [(gogoproto.enumvalue_customname) = "AttributeKeyImageURI"];
ATTRIBUTE_KEY_MINTABLE = 9 [(gogoproto.enumvalue_customname) = "AttributeKeyMintable"];
ATTRIBUTE_KEY_FROM = 10 [(gogoproto.enumvalue_customname) = "AttributeKeyFrom"];
ATTRIBUTE_KEY_TO = 11 [(gogoproto.enumvalue_customname) = "AttributeKeyTo"];
ATTRIBUTE_KEY_PERM = 12 [(gogoproto.enumvalue_customname) = "AttributeKeyPerm"];
ATTRIBUTE_KEY_APPROVER = 13 [(gogoproto.enumvalue_customname) = "AttributeKeyApprover"];
ATTRIBUTE_KEY_PROXY = 14 [(gogoproto.enumvalue_customname) = "AttributeKeyProxy"];
ATTRIBUTE_KEY_URI = 15 [(gogoproto.enumvalue_customname) = "AttributeKeyURI"];
ATTRIBUTE_KEY_IMG_URI = 8 [(gogoproto.enumvalue_customname) = "AttributeKeyImageURI"];
reserved 9 to 14;
ATTRIBUTE_KEY_URI = 15 [(gogoproto.enumvalue_customname) = "AttributeKeyURI"];
}

// EventSent is emitted when tokens are transferred.
Expand Down
Loading