Skip to content

Commit

Permalink
add test cases to avoid decreasing coverage rate
Browse files Browse the repository at this point in the history
  • Loading branch information
torao committed Jun 9, 2022
1 parent ecce1c5 commit 62f29d2
Showing 1 changed file with 55 additions and 2 deletions.
57 changes: 55 additions & 2 deletions cmd/ostracon/commands/show_validator_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ import (
"sync"
"testing"

"github.com/line/ostracon/types"

cfg "github.com/line/ostracon/config"
"github.com/line/ostracon/crypto"
tmjson "github.com/line/ostracon/libs/json"
Expand Down Expand Up @@ -94,14 +96,65 @@ func TestShowValidatorWithKMS(t *testing.T) {
}

func TestShowValidatorWithInefficientKMSAddress(t *testing.T) {
setupEnv(t)
dir := setupEnv(t)

config := cfg.DefaultConfig()
config.SetRoot(dir)
err := RootCmd.PersistentPreRunE(RootCmd, nil)
require.NoError(t, err)
init := NewInitCmd()
err = init.RunE(init, nil)
require.NoError(t, err)

if tmos.FileExists(config.PrivValidatorKeyFile()) {
err := os.Remove(config.PrivValidatorKeyFile())
require.NoError(t, err)
}
config.PrivValidatorListenAddr = "127.0.0.1:inefficient"
err := showValidator(ShowValidatorCmd, nil, config)
err = showValidator(ShowValidatorCmd, nil, config)
require.Error(t, err)
}

func TestLoadChainID(t *testing.T) {
dir := setupEnv(t)
cfg.EnsureRoot(dir)

original := config
defer func() {
config = original
}()

config = cfg.DefaultConfig()
config.SetRoot(dir)
err := RootCmd.PersistentPreRunE(RootCmd, nil)
require.NoError(t, err)
init := NewInitCmd()
err = init.RunE(init, nil)
require.NoError(t, err)
require.FileExists(t, config.GenesisFile())

genDoc, err := types.GenesisDocFromFile(config.GenesisFile())
require.NoError(t, err)
expected := genDoc.ChainID

chainID, err := loadChainID(config)
require.NoError(t, err)
require.Equal(t, expected, chainID)
}

func TestLoadChainIDWithoutStateDB(t *testing.T) {
dir := setupEnv(t)
config := cfg.DefaultConfig()
config.SetRoot(dir)
err := RootCmd.PersistentPreRunE(RootCmd, nil)
require.NoError(t, err)
init := NewInitCmd()
err = init.RunE(init, nil)
require.NoError(t, err)

config.DBPath = "/../path with containing chars that cannot be used\\/:*?\"<>|\x00"

_, err = loadChainID(config)
require.Error(t, err)
}

Expand Down

0 comments on commit 62f29d2

Please sign in to comment.