Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header and hr elements are surrounded by HTML paragraph elements in output #11

Closed
FransBouma opened this issue Feb 15, 2016 · 1 comment
Closed

Header and hr elements are surrounded by HTML paragraph elements in output #11

FransBouma opened this issue Feb 15, 2016 · 1 comment

Comments

@FransBouma
Copy link
Owner

The output is not correct, due to a bug in the markdown parser (or misconfiguration).

The snippet:

# This is a header
blablabla

will result in the following HTML:

<p><H1>This is a header></p>
<p>blablabla</p>

This isn't correct, headers shouldn't be inside P blocks. Browsers will move the p block below the header. This causes too much space which is currently compensated in the CSS for header tags (negative margin), but should be corrected in the markdown parser.
@FransBouma
Copy link
Owner Author

Fatal parser error / bug. The Markdown parser has to be replaced. We'll move to MarkdownDeep

@FransBouma FransBouma mentioned this issue Feb 15, 2016
Closed
FransBouma added a commit that referenced this issue Feb 16, 2016
@FransBouma
Several changes:
2e8e762 
- Theme has corrected margin on Header elements. It corrected an issue
in the markdown parser which wraps headers with P elements (See #11).
- Backported changes to MarkdownSharp from
https://github.com/PKRoma/MarkdownSharp/
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@FransBouma