Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link fixes #78

Merged
merged 3 commits into from
Aug 21, 2017
Merged

Conversation

GeertvanHorrik
Copy link
Contributor

@GeertvanHorrik GeertvanHorrik commented Aug 20, 2017

This PR solves 3 issues:

  1. RelativeSourceFileName was resolved against the destination instead of source
  2. Relative files inside the .md files now respect the PathSpecification. This means that if a user picks RelativeAsFolder, you can still use relative links to .md files on source, they will now be converted to the correct target url by the markdown processor.
  3. Use custom NavigationContext for search to ensure search works regardless of PathSpecification

@FransBouma
Copy link
Owner

Nice work!

Use custom NavigationContext for search to ensure search works regardless of PathSpecification

Could you elaborate a bit what this means?

@GeertvanHorrik
Copy link
Contributor Author

Before this fix, when you use a custom PathSpecification or UrlFormatting, DocNet will generate docnet-search-htm (without extension), thus breaking search.

I tried another fix before (where it would result in docnet-search/index.htm respecting the PathSpecification etc), but then search still wouldn't work (probably because docnet-search.htm is hardcoded somewhere). Therefore I just create a custom NavigationContext just for this file with no url formatting and default path specification.

@FransBouma FransBouma merged commit 7399d4b into FransBouma:master Aug 21, 2017
@FransBouma
Copy link
Owner

Yeah it's likely in the javascript search file, something that's not updated by the tool so let's leave it as you changed it.

Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants