Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommendations #5631

Open
wants to merge 9 commits into
base: development
Choose a base branch
from

Conversation

111111111111111111111111111111111111110
Copy link

Recommendations

Pull Request Type

  • Bugfix
  • Feature Implementation
  • Documentation
  • Other

Related issue

#677 (comment)

Description

this adds recommended tab to the left side menu. recommendations is based on search history. search query history is stored in local storage.

recommendation algorithm:
take 4 random past search terms, query latest videos with these terms.

Screenshots

Screenshot_2024-09-01_21-14-53

Testing

Desktop

  • OS: Debian
  • OS Version: 12
  • FreeTube version: 0.21.3

Additional context

@111111111111111111111111111111111111110 111111111111111111111111111111111111110 marked this pull request as ready for review September 1, 2024 18:41
@github-actions github-actions bot added the PR: waiting for review For PRs that are complete, tested, and ready for review label Sep 1, 2024
@FreeTubeBot FreeTubeBot enabled auto-merge (squash) September 1, 2024 18:41
@111111111111111111111111111111111111110

this is simple implementation of recommended videos feature. algorithm should be quite easy to adjust later if needed.

auto-merge was automatically disabled September 1, 2024 18:57

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) September 1, 2024 18:57
@absidue
Copy link
Member

absidue commented Sep 1, 2024

Seems interesting although before this can be properly reviewed it looks like there is a lot of unneeded code (seems like a lot was copied from the subscriptions page but without actually adapting it properly to this use case). Could you please clean that up?

@absidue absidue added PR: changes requested and removed PR: waiting for review For PRs that are complete, tested, and ready for review labels Sep 1, 2024
auto-merge was automatically disabled September 2, 2024 12:42

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) September 2, 2024 12:42
auto-merge was automatically disabled September 2, 2024 12:45

Head branch was pushed to by a user without write access

@FreeTubeBot FreeTubeBot enabled auto-merge (squash) September 2, 2024 12:45
@111111111111111111111111111111111111110

ok, did some code cleanup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants