Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail to include files with no ending LF #107

Merged
merged 1 commit into from
Jan 30, 2022
Merged

Fail to include files with no ending LF #107

merged 1 commit into from
Jan 30, 2022

Conversation

duhow
Copy link
Collaborator

@duhow duhow commented Jan 30, 2022

Fixes #106

@duhow
Copy link
Collaborator Author

duhow commented Jan 30, 2022 •
edited
Loading

Test is added in #104 , will be enabled (remove WIP) once this is merged.

@duhow duhow marked this pull request as draft January 30, 2022 12:14
@duhow
Fail to include files with no ending LF
ff25bd3 
Remove 1 line counter to get correct position
Fixes #106
@duhow duhow marked this pull request as ready for review January 30, 2022 12:36
Fubukimaru
Fubukimaru reviewed Jan 30, 2022
View reviewed changes
Copy link
Owner

@Fubukimaru Fubukimaru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@Fubukimaru Fubukimaru merged commit 8cbcd45 into master Jan 30, 2022
@duhow duhow deleted the issue-106 branch January 30, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fubukimaru Fubukimaru Fubukimaru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Including file without ending newline breaks
2 participants
@duhow @Fubukimaru