Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for agent host #259

Merged
merged 15 commits into from
Nov 3, 2023

Conversation

sammychinedu2ky
Copy link
Contributor

@sammychinedu2ky sammychinedu2ky changed the title added support for agent host Added support for agent host Nov 1, 2023
Co-authored-by: Marcin Krystianc <marcin.krystianc@gmail.com>
Co-authored-by: Marcin Krystianc <marcin.krystianc@gmail.com>
@sammychinedu2ky
Copy link
Contributor Author

So we are sticking to the set of listed os?

@marcin-krystianc
Copy link
Contributor

?

No, I think it is not a good idea to do it. I forgot to include removal of it in the first patch.
BTW, there are conflicts to be resolved.

@sammychinedu2ky
Copy link
Contributor Author

Okay 👌

@sammychinedu2ky
Copy link
Contributor Author

@marcin-krystianc I've resolved the merge conflict. please can you check it again

@sammychinedu2ky
Copy link
Contributor Author

There seems to be some failed test

@marcin-krystianc
Copy link
Contributor

There seems to be some failed test

Yeah, they look legit. Can you try to investigate what is going on?

@sammychinedu2ky
Copy link
Contributor Author

I think it stems from this
image

@sammychinedu2ky
Copy link
Contributor Author

so let me leave it and work on the other code

Consul/Agent.cs Outdated Show resolved Hide resolved
Consul.Test/AgentTest.cs Outdated Show resolved Hide resolved
@marcin-krystianc
Copy link
Contributor

so let me leave it and work on the other code

I think this change is still worth getting in. I doubt that there will be any major changes in the response body in the future.

sammychinedu2ky and others added 2 commits November 3, 2023 11:46
Co-authored-by: Marcin Krystianc <marcin.krystianc@gmail.com>
@sammychinedu2ky
Copy link
Contributor Author

I've done that.. once you approve of it, I would work on the merge conflicts

@sammychinedu2ky
Copy link
Contributor Author

Ooh cool no conflicts 😄

@marcin-krystianc marcin-krystianc merged commit fd6e131 into G-Research:master Nov 3, 2023
148 checks passed
@marcin-krystianc
Copy link
Contributor

Ooh cool no conflicts 😄

Yeah, it was good to merge. Thank you!

@sammychinedu2ky
Copy link
Contributor Author

my pleasure!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Agent Host
3 participants