Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Listing Services for Node and Retrieving Nodes that support Mesh Capable Service #273

Merged
merged 12 commits into from
Nov 29, 2023

Conversation

sammychinedu2ky
Copy link
Contributor

sammychinedu2ky and others added 8 commits October 19, 2023 09:08
Co-authored-by: Winston H. <56998716+winstxnhdw@users.noreply.github.com>
Co-authored-by: Winston H. <56998716+winstxnhdw@users.noreply.github.com>
Co-authored-by: Winston H. <56998716+winstxnhdw@users.noreply.github.com>
@sammychinedu2ky sammychinedu2ky changed the title Support for Listing Services for Nodes Support for Listing Services for Node Nov 28, 2023
Copy link
Contributor

@marcin-krystianc marcin-krystianc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just few minor comments, looks good in general.

Consul/Catalog.cs Outdated Show resolved Hide resolved
Consul.Test/CatalogTest.cs Show resolved Hide resolved
Consul.Test/CatalogTest.cs Show resolved Hide resolved
Consul/Catalog.cs Outdated Show resolved Hide resolved
@sammychinedu2ky sammychinedu2ky changed the title Support for Listing Services for Node Support for Listing Services for Node and Retrieving Nodes that support Mesh Capable Service Nov 29, 2023
@sammychinedu2ky
Copy link
Contributor Author

done @marcin-krystianc 🚀. thank you

Copy link
Contributor

@marcin-krystianc marcin-krystianc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@marcin-krystianc marcin-krystianc merged commit ed29db8 into G-Research:master Nov 29, 2023
160 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for Listing Services for Node and Retrieving Nodes that support Mesh Capable Service
2 participants