Add "solver" and "max_iter" parameters to class LogisticRegression #435
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #435 +/- ##
========================================
Coverage 80.20% 80.20%
========================================
Files 93 93
Lines 7289 7291 +2
========================================
+ Hits 5846 5848 +2
Misses 1443 1443
Continue to review full report at Codecov.
|
| @@ -93,7 +104,7 @@ def fit( # noqa: D102 | |||
| selected_indexes = np.zeros(self.p, dtype=np.intc) | |||
|
|
|||
| # multivariate logistic regression | |||
| mvlr = mvLogisticRegression(penalty='l2') | |||
| mvlr = mvLogisticRegression(penalty='l2', solver=self.solver, max_iter=self.max_iter) | |||
There was a problem hiding this comment.
This line is over 79 characters. Split it in multiple lines.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1,4 +1,5 @@ | |||
| from __future__ import annotations | |||
| import string | |||
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
I003 isort expected 1 blank line in imports, found 0
| @@ -30,6 +31,12 @@ class LogisticRegression( | |||
| p: | |||
| number of points (and coefficients) to be selected by | |||
| the algorithm. | |||
| solver: | |||
| Algorithm to use in the multivariate logistic regresion | |||
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
W291 trailing whitespace
| @@ -93,7 +104,11 @@ def fit( # noqa: D102 | |||
| selected_indexes = np.zeros(self.p, dtype=np.intc) | |||
|
|
|||
| # multivariate logistic regression | |||
| mvlr = mvLogisticRegression(penalty='l2') | |||
| mvlr = mvLogisticRegression( | |||
| penalty='l2', | |||
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
W291 trailing whitespace
| mvlr = mvLogisticRegression(penalty='l2') | ||
| mvlr = mvLogisticRegression( | ||
| penalty='l2', | ||
| solver=self.solver, |
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
W291 trailing whitespace
| @@ -73,9 +80,13 @@ class LogisticRegression( | |||
| def __init__( | |||
| self, | |||
| p: int = 5, | |||
| solver: string = 'lbfgs', | |||
There was a problem hiding this comment.
🚫 [mypy] reported by reviewdog 🐶
Module "string" is not valid as a type
| @@ -73,9 +79,13 @@ class LogisticRegression( | |||
| def __init__( | |||
| self, | |||
| p: int = 5, | |||
| solver: str = 'lbfgs', | |||
There was a problem hiding this comment.
This should have a Literal type with the acceptable values.
No description provided.