Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rst #449

Merged
merged 3 commits into from
May 31, 2022
Merged

Add rst #449

merged 3 commits into from
May 31, 2022

Conversation

alvaro-castillo
Copy link
Contributor

No description provided.

@alvaro-castillo alvaro-castillo self-assigned this May 17, 2022
@codecov
Copy link

codecov bot commented May 17, 2022

Codecov Report

Merging #449 (e4f705d) into develop (5094aa1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop     #449   +/-   ##
========================================
  Coverage    80.30%   80.30%           
========================================
  Files           93       93           
  Lines         7333     7333           
========================================
  Hits          5889     5889           
  Misses        1444     1444           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5094aa1...e4f705d. Read the comment docs.

--------------------

It is crucial to create features from the original ones so they can be
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"crucial" is maybe too exaggerated. It is an important technique, for sure, but not "crucial".

---------------------

This method deals with the extraction of features depending on the class
label of each observation. It will apply a different transformation to each
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a very misleading description. It applies as many transformation as classes to EVERY observation. Each transformation is fitted using only the training data of a particular class.

@vnmabus vnmabus merged commit 4e720c3 into develop May 31, 2022
@alvaro-castillo alvaro-castillo deleted the feature/addRST branch June 7, 2022 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants