-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix FPCA grid implementation with regularization #485
Conversation
In doing this Cholesky decomposition, we can change the data to a new basis before fitting it and undo the change after calling to multivariate PCA.
Codecov ReportBase: 85.52% // Head: 85.53% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #485 +/- ##
========================================
Coverage 85.52% 85.53%
========================================
Files 141 141
Lines 11277 11280 +3
========================================
+ Hits 9645 9648 +3
Misses 1632 1632
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Is this still a draft? |
@vnmabus, I just forgot to mark it as ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It has not been fixed completely, as there seems to be an issue with the penalization factor. However, now the components obtained are not orthogonal.
This was achieved by performing Cholesky decomposition. In doing this Cholesky decomposition, we can change the data to a new basis before fitting it and undo the change after calling the multivariate PCA.