Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed Gramian matrix to Gram matrix for better consistency. Issue #501. #502

Merged
merged 4 commits into from
Dec 29, 2022

Conversation

Saumya-ranjan
Copy link
Contributor

No description provided.

@Saumya-ranjan Saumya-ranjan changed the title Changed gramian to gram for better consistency. Changed Gramian matrix to Gram matrix for better consistency. Issue #501. Dec 24, 2022
Copy link
Contributor Author

@Saumya-ranjan Saumya-ranjan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed Gramian Matrix to Gram Matrix for better consistency.
Files Changed - 7
Lines Affected - 34

Copy link
Member

@vnmabus vnmabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is exactly it. Let me fix the CI first, and I will accept this then.

@codecov
Copy link

codecov bot commented Dec 29, 2022

Codecov Report

Base: 85.41% // Head: 85.41% // No change to project coverage 👍

Coverage data is based on head (5a222a6) compared to base (f1d3887).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #502   +/-   ##
========================================
  Coverage    85.41%   85.41%           
========================================
  Files          139      139           
  Lines        11103    11103           
========================================
  Hits          9484     9484           
  Misses        1619     1619           
Impacted Files Coverage Δ
skfda/misc/_math.py 84.37% <ø> (ø)
skfda/misc/operators/_identity.py 88.88% <100.00%> (ø)
...da/misc/operators/_linear_differential_operator.py 95.74% <100.00%> (ø)
skfda/misc/operators/_operators.py 91.17% <100.00%> (ø)
skfda/misc/regularization/_regularization.py 94.28% <100.00%> (ø)
skfda/tests/test_regularization.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Saumya-ranjan
Copy link
Contributor Author

Thankyou!! @vnmabus

@vnmabus vnmabus merged commit 38118d5 into GAA-UAM:develop Dec 29, 2022
@Saumya-ranjan Saumya-ranjan deleted the change_gramian_to_gram branch December 29, 2022 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants