Deprecate 3 as the default number of components in FPCA #510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is only to circunvent the deprecation warning added to the constructor of FPCA regarding the default number of components
Codecov ReportBase: 85.53% // Head: 85.51% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #510 +/- ##
===========================================
- Coverage 85.53% 85.51% -0.02%
===========================================
Files 141 141
Lines 11280 11284 +4
===========================================
+ Hits 9648 9650 +2
- Misses 1632 1634 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
vnmabus
requested changes
Feb 1, 2023
vnmabus
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As outlined in #507, when the number of components is not specified, all components should be extracted. A deprecation warning has been added to alert the users that were relying on the default value of components being 3. The documentation has also been updated accordingly.