Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correction=0 by default in cov and var functions #582

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

pcuestas
Copy link
Contributor

(and explicitly set the correction value where it was not set, to avoid changing the previous behavior of the modules).

Closes #581

(and explicitly set the correction value where it was not set,
to avoid changing the previous behavior of the modules)
@pcuestas pcuestas requested a review from vnmabus October 12, 2023 08:18
@pcuestas pcuestas linked an issue Oct 12, 2023 that may be closed by this pull request
@pcuestas pcuestas changed the title Set correction=0 by default Set correction=0 by default in cov and var functions Oct 12, 2023
@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (febfe36) 86.03% compared to head (e4a35c7) 86.03%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #582   +/-   ##
========================================
  Coverage    86.03%   86.03%           
========================================
  Files          148      148           
  Lines        11717    11717           
========================================
  Hits         10081    10081           
  Misses        1636     1636           
Files Coverage Δ
skfda/exploratory/stats/_stats.py 85.00% <100.00%> (ø)
skfda/inference/anova/_anova_oneway.py 89.15% <ø> (ø)
skfda/inference/hotelling/_hotelling.py 91.78% <ø> (ø)
skfda/misc/covariances.py 84.40% <100.00%> (ø)
skfda/representation/_functional_data.py 83.15% <ø> (ø)
skfda/representation/basis/_fdatabasis.py 82.21% <ø> (ø)
skfda/representation/grid.py 87.30% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@vnmabus vnmabus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vnmabus vnmabus merged commit c512c0b into develop Oct 12, 2023
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default correction=0 for cov, var
2 participants