Integrate FDataIrregular using scipy.integrate.simpson on each curve separately
#608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -23,6 +22,7 @@ | |||
| import numpy as np | |||
| import pandas.api.extensions | |||
| from matplotlib.figure import Figure | |||
| import scipy | |||
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
I001 isort found an import in the wrong position
skfda/representation/irregular.py
Outdated
| raise NotImplementedError() | ||
| if self.dim_domain != 1: | ||
| raise NotImplementedError( | ||
| "Integration only implemented for 1D domains." |
There was a problem hiding this comment.
[pep8] reported by reviewdog 🐶
C812 missing trailing comma
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #608 +/- ##
========================================
Coverage 86.65% 86.65%
========================================
Files 156 156
Lines 13314 13322 +8
========================================
+ Hits 11537 11544 +7
- Misses 1777 1778 +1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the proposed changes
Integration for irregular curves has been implemented using
scipy.integrate.simpsonto integrate irregular curves (of 1-dimensional domain) one by one.Additional information
We have not agreed on how integration of irregular data with higher dimensional domains should be defined, so it is not to be implemented yet.
This is a first implementation which may or may not be later improved by manually computing simpson's coefficients, multiply them against the curves' values and calling
skfda.representation.irregular._reduceatto add the results.