Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ 改用 @DBRef 註解搜尋關聯 #108

Merged
merged 1 commit into from
Jul 3, 2023
Merged

♻️ 改用 @DBRef 註解搜尋關聯 #108

merged 1 commit into from
Jul 3, 2023

Conversation

frankvicky
Copy link
Collaborator

Why need this change? / Root cause:

  • 改用 @DBREF 註解搜尋關聯，省去手動 Query 的麻煩。

Changes made:

  • RoomData

Test Scope / Change impact:

  • none

Issue

  • none

@frankvicky frankvicky requested a review from Wally5077 July 2, 2023 08:02
@sonarcloud
Copy link

sonarcloud bot commented Jul 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Wally5077
Wally5077 approved these changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@Wally5077 Wally5077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frankvicky frankvicky merged commit 9d44916 into main Jul 3, 2023
5 checks passed
@frankvicky frankvicky deleted the refactor/dbRef branch July 3, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wally5077 Wally5077 Wally5077 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frankvicky @Wally5077