Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/join room full #73

Merged
merged 5 commits into from
Jul 1, 2023
Merged

Feature/join room full #73

merged 5 commits into from
Jul 1, 2023

Conversation

mikaeloduh
Copy link
Contributor

@mikaeloduh mikaeloduh commented May 28, 2023 •
edited by ricksu978
Loading

Why need this change? / Root cause:

  • Exception when room is full

Changes made:

  • Add maximum player validation

Test Scope / Change impact:

  • JoinRoomUsecase

Ticket

@mikaeloduh mikaeloduh self-assigned this May 28, 2023
@mikaeloduh mikaeloduh linked an issue May 28, 2023 that may be closed by this pull request
房間人數已滿 #54
Closed
@mikaeloduh
Copy link
Contributor Author

第一次寫 Spring Kotlin，請小力鞭。

@ricksu978 ricksu978 requested review from Wally5077 and removed request for Johnny850807 June 25, 2023 09:22
frankvicky
frankvicky requested changes Jun 25, 2023
View reviewed changes
domain/src/main/kotlin/tw/waterballsa/gaas/domain/Room.kt Outdated
Comment on lines 27 to 29
fun isFull(): Boolean {
return players.size >= maxPlayers
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fun isFull(): Boolean = players.size >= maxPlayers

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

修正在 1161add

Wally5077
Wally5077 requested changes Jun 25, 2023
View reviewed changes
Copy link
Collaborator

@Wally5077 Wally5077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review done.

application/src/main/kotlin/tw/waterballsa/gaas/application/usecases/JoinRoomUsecase.kt Outdated Show resolved Hide resolved
application/src/main/kotlin/tw/waterballsa/gaas/application/usecases/JoinRoomUsecase.kt Outdated Show resolved Hide resolved
spring/src/test/kotlin/tw/waterballsa/gaas/spring/it/controllers/RoomControllerTest.kt Outdated Show resolved Hide resolved
spring/src/test/kotlin/tw/waterballsa/gaas/spring/it/controllers/RoomControllerTest.kt Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jun 29, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mikaeloduh mikaeloduh removed the request for review from lohas1107 July 1, 2023 13:10
Wally5077
Wally5077 approved these changes Jul 1, 2023
View reviewed changes
Copy link
Collaborator

@Wally5077 Wally5077 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikaeloduh mikaeloduh merged commit 8530b4e into main Jul 1, 2023
5 checks passed
@mikaeloduh mikaeloduh deleted the feature/join-room-full branch July 1, 2023 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wally5077 Wally5077 Wally5077 approved these changes

@frankvicky frankvicky frankvicky approved these changes

Assignees

@mikaeloduh mikaeloduh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

房間人數已滿
3 participants
@mikaeloduh @Wally5077 @frankvicky