Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This PR is related to Issue #489. privacypolicy.html has been added #491

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Priyank00007
Copy link

@Priyank00007 Priyank00007 commented Oct 11, 2024

Pull Request for Resum-Resume 💡

Issue Title : Privacy Policy Page Missing

Name: Priyank Jain
GItHub Id: Priyank00007
Email Id: priyankjain795@gmail.com

Closes: #489

I have created a privacy policy page with same UI of the about page of Resum Resume.

Type of change ☑️

What sort of change have you made:

  • New feature: Privacy Policy page is being displayed on the website.

image

Checklist: ☑️

  • My code follows the guidelines of this project.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly wherever it was hard to understand.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added things that prove my fix is effective or that my feature works.
  • Any dependent changes have been merged and published in downstream modules.

@GarimaSingh0109
Copy link
Owner

GarimaSingh0109 commented Oct 12, 2024

@Priyank00007 you have created a button for this page in navbar??
if not do create a button for the same

@Priyank00007
Copy link
Author

@Priyank00007 you have created a button for this page in navbar?? if not do create a button for the same

I have created the button for this on navbar of privacy policy page but not on all pages so should i create the button for all pages?

@Priyank00007
Copy link
Author

@Priyank00007 you have created a button for this page in navbar?? if not do create a button for the same

I have created the button for all navbar in all pages
image
image

@Priyank00007
Copy link
Author

@GarimaSingh0109 is this issue completed?

@Priyank00007
Copy link
Author

@GarimaSingh0109 mam can u close this issue please

@Priyank00007
Copy link
Author

@GarimaSingh0109 mam can u merge it with main

@Priyank00007
Copy link
Author

@GarimaSingh0109 I have removed the conflicts present

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: Privacy Policy Page Missing
2 participants