Re rebalance coherence #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coherence feature and run rustfmt
This removes quite a lot of dirty hacks from diesel-oci
pgab
reviewed
Jan 8, 2019
| @@ -0,0 +1 @@ | |||
| nightly-2019-01-07 | |||
There was a problem hiding this comment.
Can we do this w/o updating GST (as of now) or does this probably have invocations for GST as well?
There was a problem hiding this comment.
We need to bump rustc for GST as well because everything needs to be build with the same compiler version. We don't need to use this specific nightly, any new one should also work. (To be more concrete: We should not use this one, because it contains no working rls build…)
That was the plan (at least to have it in separate commits), but it seems like |
added 4 commits
January 8, 2019 18:33
… ELSE 0 END FROM DUAL`
`INSERT INTO table (columns...) select :1 from dual union all select :2 from dual union all select :3 from dual`
…way to handle this
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would be great if someone could test that the tests actually work (They just compile…)
If there are test errors we need to tweak the generated sql in the
QueryFragmentimplementations.Addresses #7