Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to v0.6 #16

Merged
merged 1 commit into from
Mar 6, 2020
Merged

Bump version to v0.6 #16

merged 1 commit into from
Mar 6, 2020

Conversation

Gnimuc
Copy link
Owner

@Gnimuc Gnimuc commented Mar 5, 2020

Hey @dourouc05, are you still using this package? @francescoalemanno have made some improvements in PR #15. I just want to make sure this new release won't break your code. :)

@dourouc05
Copy link
Contributor

Thank you for thinking of me :)! Yes, I still use it, albeit performance is now slightly less relevant for me. I think it will break my code, though, but I have to test it.

Just about the deprecation: I'm not sure

@deprecate munkres!(costMat::AbstractMatrix{<:Real}) munkres(costMat::AbstractMatrix{<:Real})
is enough, as the mutating method is replaced by a nonmutating one, it's not a simple function call (the function call should be replaced by a variable assignment).

@francescoalemanno
Copy link
Contributor

francescoalemanno commented Mar 5, 2020

if you guys need an imitation of the old mutating method it suffices to:

  1. from each row where there is an assigned position (a starred zero), subtract from the row the cost of that position
  2. for each column subtract the minimum of the column
  3. go to step 1, until no changes

this algorithm given the optimal assignments and the cost matrix will produce the mutated matrix of the munkres algorithm

@dourouc05
Copy link
Contributor

On my side, just removing the ! worked (no deprecation warning, no behaviour change as per my test suite). I'll just be waiting for the new version to be tagged so I can do so on my package :)!

Gnimuc added a commit that referenced this pull request Mar 6, 2020
see this post on how to reserve the old behavior: #16 (comment)
@Gnimuc Gnimuc merged commit 09e909c into master Mar 6, 2020
@Gnimuc Gnimuc deleted the release-v0.6 branch March 6, 2020 00:07
@Gnimuc
Copy link
Owner Author

Gnimuc commented Mar 6, 2020

I dropped munkres! on this release and mentioned #16 (comment) in the commit log. Anyway, it's not hard to find the proper fix in this small package when the code is broken.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants