-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Text Sets: make use of custom heading levels #10724
Comments
<h1>
H1s are only used if the font size is 36 or larger. The title here only has font size 31. It's the only cover text set with such a font size. We can consider lowering the threshold or simply forcing it to be an H1. |
🤔 I think it's probably ok as is. I feel like if we were to force an h2 into being an h1 just because there was no h1 present it could be more of a hinderance - like, how to select the "right" h2. Knowing it's for 36 or larger clears up my confusion and for users who notice this, they'll understand. |
Forcing/Defaulting to h1 also really only works when there's UI to override that again, which is not currently planned. So yeah, probably easiest to just leave this as-is and make sure it's documented. |
Related: #11363 |
<h1>
Tested using PR #12031.
|
Bug Description
Originally reported by @BrittanyIRL
I added two of the same cover text sets and previewed, I have 0 h1s but 2 h2s. I think this is just because of how the text set was created?
Expected Behaviour
Steps to Reproduce
Screenshots
Additional Context
The text was updated successfully, but these errors were encountered: