Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text Sets: make use of custom heading levels #10724

Closed
bmattb opened this issue Feb 25, 2022 · 5 comments · Fixed by #12031
Closed

Text Sets: make use of custom heading levels #10724

bmattb opened this issue Feb 25, 2022 · 5 comments · Fixed by #12031
Assignees
Labels
Elements: Text Group: Text Sets List of predefined groups of text elements P1 High priority, must do soon Type: Enhancement New feature or improvement of an existing feature

Comments

@bmattb
Copy link

bmattb commented Feb 25, 2022

Bug Description

Originally reported by @BrittanyIRL
I added two of the same cover text sets and previewed, I have 0 h1s but 2 h2s. I think this is just because of how the text set was created?

image15

Expected Behaviour

Steps to Reproduce

Screenshots

Additional Context

  • Plugin Version:
  • WordPress Version:
  • Operating System:
  • Browser:
@bmattb bmattb added Type: Bug Something isn't working Pod: Prometheus labels Feb 25, 2022
@bmattb bmattb added Elements: Text Group: Text Presets List of predefined text elements with specific styles Group: Text Sets List of predefined groups of text elements labels Feb 25, 2022
@swissspidy swissspidy assigned swissspidy and unassigned miina Feb 25, 2022
@swissspidy swissspidy removed the Group: Text Presets List of predefined text elements with specific styles label Feb 25, 2022
@swissspidy swissspidy changed the title Adding two cover templates to one page results in multiple H2's on page Text Sets: "Healthy habits" title not using <h1> Feb 25, 2022
@swissspidy
Copy link
Collaborator

H1s are only used if the font size is 36 or larger. The title here only has font size 31.

It's the only cover text set with such a font size.

We can consider lowering the threshold or simply forcing it to be an H1.

@BrittanyIRL
Copy link
Contributor

H1s are only used if the font size is 36 or larger. The title here only has font size 31.
It's the only cover text set with such a font size.
We can consider lowering the threshold or simply forcing it to be an H1.

🤔 I think it's probably ok as is. I feel like if we were to force an h2 into being an h1 just because there was no h1 present it could be more of a hinderance - like, how to select the "right" h2. Knowing it's for 36 or larger clears up my confusion and for users who notice this, they'll understand.

@swissspidy
Copy link
Collaborator

Forcing/Defaulting to h1 also really only works when there's UI to override that again, which is not currently planned. So yeah, probably easiest to just leave this as-is and make sure it's documented.

@BrittanyIRL BrittanyIRL added the Status: Not Applicable Issue that cannot be confirmed or is not an actual issue. label Mar 18, 2022
@swissspidy
Copy link
Collaborator

Related: #11363

@swissspidy swissspidy added P3 Nice to have and removed Status: Not Applicable Issue that cannot be confirmed or is not an actual issue. labels Apr 27, 2022
@swissspidy swissspidy added P2 Should do soon and removed P3 Nice to have labels Jul 11, 2022
@swissspidy swissspidy removed their assignment Jul 11, 2022
@swissspidy swissspidy added Type: Enhancement New feature or improvement of an existing feature and removed Type: Bug Something isn't working labels Jul 18, 2022
@swissspidy swissspidy changed the title Text Sets: "Healthy habits" title not using <h1> Text Sets: make use of custom heading levels Jul 18, 2022
@swissspidy swissspidy added P1 High priority, must do soon and removed P2 Should do soon Pod: Prometheus labels Jul 20, 2022
@felipebochehin87
Copy link

Tested using PR #12031.

  1. Added multiple text elements to a blank canvas
  2. Changed their position and confirmed that the Title 1 that is at the top of the page is the H1
  3. Other texts meet the expected too
  4. Used a template
  5. Changed font size:
    H1: 36 or greater
    H2: 27-35
    H3: 21-26
    P: 8-20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Elements: Text Group: Text Sets List of predefined groups of text elements P1 High priority, must do soon Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants