Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text Sets: make use of custom heading levels #12031

Merged
merged 4 commits into from
Jul 28, 2022

Conversation

timarney
Copy link
Contributor

@timarney timarney commented Jul 27, 2022

Context

Updates cover text sets to ensure "primary" title gets assigned an H1 tag

Summary

Updates cover text sets

Relevant Technical Choices

To-do

User-facing changes

Testing Instructions

  • This is a non-user-facing change and requires no QA

This PR can be tested by following these steps:

1). Create new story
2) Add each cover text set to a page
3) Ensure the primary title is showing as an H1 (Style -> Accessibility -> heading level)

Screen Shot 2022-07-27 at 4 43 36 PM

Reviews

Does this PR have a security-related impact?

No

Does this PR change what data or activity we track or use?

No

Does this PR have a legal-related impact?

No

Checklist

  • This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • I have tested this code to the best of my abilities
  • I have verified accessibility to the best of my abilities (docs)
  • I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
  • I have added documentation where necessary
  • I have added a matching Type: XYZ label to the PR

Fixes #10724

@timarney timarney self-assigned this Jul 27, 2022
@timarney timarney added Group: Text Sets List of predefined groups of text elements Elements: Text Pod: WP Type: Enhancement New feature or improvement of an existing feature labels Jul 27, 2022
@timarney timarney marked this pull request as ready for review July 27, 2022 20:50
@googleforcreators-bot
Copy link
Collaborator

Plugin builds for 98010f2 are ready 🛎️!

@swissspidy swissspidy merged commit 49e38d2 into main Jul 28, 2022
@swissspidy swissspidy deleted the fix/10724-ensure-heading-level branch July 28, 2022 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Elements: Text Group: Text Sets List of predefined groups of text elements Type: Enhancement New feature or improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Text Sets: make use of custom heading levels
3 participants